test: extract repeated literals in sync_skills_test to constants#1185
Merged
test: extract repeated literals in sync_skills_test to constants#1185
Conversation
Follow-up to the merged sync-skills work: `"security-review"` (9 occurrences) and `"https://github.com/foo/bar"` (6 occurrences) were flagged by goconst under the current golangci-lint version. Extract them to package-level constants alongside the existing `originalRef` / `bumpedRef` block. Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Contributor
Registry Build PreviewAll registries built successfully! Registry:
|
stacklokbot
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the merged sync-skills work. The post-merge lint baseline still flags two
goconstissues incmd/catalog/sync_skills_test.go:"security-review"— 9 standalone occurrences (test fixture skill name used as map key, filepath component, etc.)"https://github.com/foo/bar"— 6 standalone occurrences (repoURLsMatchtest cases)Extracted both to package-level constants (
securityReview,fixtureRepoURL) alongside the existingoriginalRef/bumpedRefblock. Tests still pass; full-repo lint is0 issues.Test plan
go test ./cmd/catalog/...— passes.golangci-lint run ./...—0 issues.