Commit 1ef910e
committed
Tighten
The godoc previously said the nil-claims-to-{} normalisation was
"unreachable in practice" under authz — that's wrong for super-admin,
who bypasses the subset check uniformly and would hit that branch
when reading legacy or synced rows that lack claims. Reword to call
out the super-admin path explicitly so the next reader doesn't trust
a stale invariant.
Add `TestGetEntryClaims_SuperAdminBypassesSubsetCheck` at the db
layer: super-admin caller with non-covering JWT claims still reads
the entry. Pairs with the existing cross-team-denied case to lock in
both halves of the bypass contract.getEntryClaims godoc and cover super-admin bypass1 parent d761d67 commit 1ef910e
2 files changed
Lines changed: 38 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
208 | | - | |
209 | | - | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
210 | 211 | | |
211 | 212 | | |
212 | 213 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
97 | 98 | | |
98 | 99 | | |
99 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
100 | 134 | | |
101 | 135 | | |
102 | 136 | | |
| |||
0 commit comments