Drop legacy registry format from examples, chart, and docs#774
Drop legacy registry format from examples, chart, and docs#774
Conversation
The legacy ToolHive registry schema is no longer parsed by the server, which now consumes only the MCP Registry v0.1 format. Drop the `toolhive-registry.json` fixture, retire the dual-format demo in `config-docker-dual.yaml` (rewriting it as two upstream sources with distinct name filters), and remove the redundant legacy file source from `config-docker-multiple.yaml`. Repoint every git-based example config to `pkg/catalog/toolhive/data/registry-upstream.json` in `stacklok/toolhive-catalog`, and rewrite the data-format section of `examples/README.md` to describe a single supported format. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The Helm chart's default git path and the configuration/deployment guides still pointed at the deprecated `registry-legacy.json` catalog file, so a fresh `helm install` would have pulled data the server can no longer parse. Switch every default and example to `registry-upstream.json` and regenerate the chart's auto-produced `README.md` via `helm-docs`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
=======================================
Coverage ? 61.05%
=======================================
Files ? 108
Lines ? 10593
Branches ? 0
=======================================
Hits ? 6468
Misses ? 3547
Partials ? 578 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@claude Has our friend @rdimitrov missed any reference examples of the legacy format from this codebase? |
|
@claude did I missed any reference examples of the legacy format from this codebase? |
|
Claude finished @rdimitrov's task in 1m 10s —— View job Legacy format reference audit
No missed references found. The sweep was exhaustive — searched all
All the changed files in this PR have been properly updated, and the deleted
|
Summary
pkg/catalog/toolhive/data/registry-legacy.jsonand shipping a legacy-format example file.pkg/catalog/toolhive/data/registry-upstream.json(the upstream-format file already living instacklok/toolhive-catalog), deletes theexamples/toolhive-registry.jsonfixture, and trims sample configs that previously demoed both formats.Notable example reshuffles
config-docker-dual.yamlno longer demos two formats; rewritten as two upstream sources with distinct per-source name filters (database-* vs git-*).config-docker-multiple.yamldrops the redundanttoolhive-filesource; still demos file/api/git source kinds.examples/README.mddata-format section collapsed to describe the single supported format and the API-source description no longer mentions an old "convert from upstream to ToolHive" step.Test plan
task gentask lint-fix— 0 issuesgo test ./examples/...— allconfig-*.yamlvalidate againstinternal/confighelm lint deploy/charts/toolhive-registry-serverandhelm templatesucceeddeploy/charts/toolhive-registry-server/README.mdregenerated viahelm-docshelm templateof the chart produces a ConfigMap withpath: pkg/catalog/toolhive/data/registry-upstream.json(and noregistry-legacy.jsonreferences)🤖 Generated with Claude Code