Skip to content

Drop legacy registry format from examples, chart, and docs#774

Merged
rdimitrov merged 3 commits intomainfrom
pinnate-cesium
May 6, 2026
Merged

Drop legacy registry format from examples, chart, and docs#774
rdimitrov merged 3 commits intomainfrom
pinnate-cesium

Conversation

@rdimitrov
Copy link
Copy Markdown
Member

@rdimitrov rdimitrov commented May 6, 2026

Summary

  • The server only consumes the MCP Registry v0.1 (upstream) format — the legacy ToolHive schema is no longer parsed, but examples, the Helm chart, and the docs were still steering users toward pkg/catalog/toolhive/data/registry-legacy.json and shipping a legacy-format example file.
  • Replaces all references with pkg/catalog/toolhive/data/registry-upstream.json (the upstream-format file already living in stacklok/toolhive-catalog), deletes the examples/toolhive-registry.json fixture, and trims sample configs that previously demoed both formats.
  • No Go code changes — earlier sweep confirmed no parsers, conversion code, or types specific to the legacy format remained.

Notable example reshuffles

  • config-docker-dual.yaml no longer demos two formats; rewritten as two upstream sources with distinct per-source name filters (database-* vs git-*).
  • config-docker-multiple.yaml drops the redundant toolhive-file source; still demos file/api/git source kinds.
  • examples/README.md data-format section collapsed to describe the single supported format and the API-source description no longer mentions an old "convert from upstream to ToolHive" step.

Test plan

  • task gen
  • task lint-fix — 0 issues
  • go test ./examples/... — all config-*.yaml validate against internal/config
  • helm lint deploy/charts/toolhive-registry-server and helm template succeed
  • Auto-generated deploy/charts/toolhive-registry-server/README.md regenerated via helm-docs
  • Manual smoke test: helm template of the chart produces a ConfigMap with path: pkg/catalog/toolhive/data/registry-upstream.json (and no registry-legacy.json references)
  • CI passes

🤖 Generated with Claude Code

rdimitrov and others added 2 commits May 7, 2026 00:39
The legacy ToolHive registry schema is no longer parsed by the server,
which now consumes only the MCP Registry v0.1 format. Drop the
`toolhive-registry.json` fixture, retire the dual-format demo in
`config-docker-dual.yaml` (rewriting it as two upstream sources with
distinct name filters), and remove the redundant legacy file source from
`config-docker-multiple.yaml`. Repoint every git-based example config to
`pkg/catalog/toolhive/data/registry-upstream.json` in
`stacklok/toolhive-catalog`, and rewrite the data-format section of
`examples/README.md` to describe a single supported format.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The Helm chart's default git path and the configuration/deployment
guides still pointed at the deprecated `registry-legacy.json` catalog
file, so a fresh `helm install` would have pulled data the server can
no longer parse. Switch every default and example to
`registry-upstream.json` and regenerate the chart's auto-produced
`README.md` via `helm-docs`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@fa6d401). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage        ?   61.05%           
=======================================
  Files           ?      108           
  Lines           ?    10593           
  Branches        ?        0           
=======================================
  Hits            ?     6468           
  Misses          ?     3547           
  Partials        ?      578           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisJBurns
Copy link
Copy Markdown
Contributor

@claude Has our friend @rdimitrov missed any reference examples of the legacy format from this codebase?

@rdimitrov
Copy link
Copy Markdown
Member Author

@claude did I missed any reference examples of the legacy format from this codebase?

@claude
Copy link
Copy Markdown

claude Bot commented May 6, 2026

Claude finished @rdimitrov's task in 1m 10s —— View job


Legacy format reference audit

  • Gather context and understand the request
  • Search for remaining registry-legacy.json references
  • Search for remaining toolhive-registry.json references
  • Search for other legacy format indicators
  • Report findings

No missed references found. The sweep was exhaustive — searched all .go, .yaml, .yml, .json, .md, .toml, .html, .ts, and .js files for:

  • registry-legacy0 hits
  • toolhive-registry.json0 hits
  • legacy (case-insensitive) — 3 hits, none related to the registry format:
    • internal/sync/manager_test.go:114 — a comment about stale IN_PROGRESS DB rows ("legacy data"), unrelated to the file format
    • internal/filtering/filter_service_test.go:235,238 — a test fixture named "legacy-api" and a test URL legacy.example.com, both unrelated
  • pkg/catalog/toolhive/data/ path — all 20+ occurrences now correctly reference registry-upstream.json

All the changed files in this PR have been properly updated, and the deleted examples/toolhive-registry.json fixture has no surviving references. The PR is clean.

CI is also green ✓

@rdimitrov rdimitrov merged commit 268c01b into main May 6, 2026
14 checks passed
@rdimitrov rdimitrov deleted the pinnate-cesium branch May 6, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants