Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
==========================================
+ Coverage 60.48% 60.50% +0.01%
==========================================
Files 108 108
Lines 10580 10580
==========================================
+ Hits 6399 6401 +2
+ Misses 3611 3610 -1
+ Partials 570 569 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cd47b1c to
d2dadac
Compare
5 tasks
rdimitrov
added a commit
that referenced
this pull request
May 5, 2026
## Summary - `golangci-lint` v2.12.1 tightened `goconst` and added a `govet` `inline` check, making CI red on every open PR (#766, #767, future renovates) even though no code changed - Excludes `goconst` from `_test.go` and test-fixture files (in line with the existing `lll`/`gocyclo`/`errcheck`/`dupl`/`gosec` test exclusions) — table-driven fixtures read better inline than hoisted - Fixes the production-code findings properly with named constants (audit target field keys, kubernetes registry/transport types via upstream `model.*`, telemetry `DefaultServiceVersion`, etc.) and replaces `reflect.Ptr` with `reflect.Pointer` in `marshalJSONOrNil` for the new `govet` rule ## Why this exists separately This is purely a CI unblocker — none of the underlying code is broken, only the linter shifted under us. Keeping it as its own PR so #766, #767 and the next batch of renovate PRs can rebase onto a green `main` without absorbing this churn. ## Test plan - [x] `golangci-lint run --timeout=5m` — `0 issues` - [x] `go build ./...` — clean - [x] `go test -short ./internal/audit/... ./internal/config/... ./internal/kubernetes/... ./internal/telemetry/...` — green - [ ] CI: `Linting / Lint Go Code` passes - [ ] CI: full test matrix passes (the renamed audit map keys and kubernetes constants are exercised by the existing test suites) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
d2dadac to
717e7f9
Compare
rdimitrov
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
11a9dad→2cc1ac195e58e9→e46ed2cConfiguration
📅 Schedule: (UTC)
* 0-3 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.