Skip to content

examples: add TweetClaw skill registry fixture#816

Open
kriptoburak wants to merge 2 commits into
stacklok:mainfrom
kriptoburak:codex/add-tweetclaw-skill-example
Open

examples: add TweetClaw skill registry fixture#816
kriptoburak wants to merge 2 commits into
stacklok:mainfrom
kriptoburak:codex/add-tweetclaw-skill-example

Conversation

@kriptoburak

Copy link
Copy Markdown

Summary:

  • Adds a ToolHive skill entry for TweetClaw to examples/upstream-registry.json.
  • Uses a pinned Git package reference to the public skills/tweetclaw folder.
  • Extends TestExampleFiles to assert skill count and package fields.

Validation:

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d64508ba8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread examples/upstream-registry.json Outdated
Comment on lines +1211 to +1212
"ref": "master",
"commit": "7113d9e534a94f8279438b1373f741343c39523a",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point the Git ref at the pinned version

This skill is registered as version 1.6.32 and pins commit 7113d9e..., but the package also tells clients to resolve ref: master; at the time of review, master serves the older 1.6.31 package while the pinned commit serves 1.6.32. Any client that fetches by ref first, especially with a shallow clone before checking out/verifying the commit, will either install the wrong tree or fail to find the pinned commit. Use a tag/branch that contains 7113d9e... or omit the moving ref so the Git package is reproducible.

Useful? React with 👍 / 👎.

@kriptoburak

Copy link
Copy Markdown
Author

Addressed the Codex review by removing the moving Git ref from the TweetClaw skill package and relying on the pinned commit for reproducible checkout. I also added a test assertion for the pinned commit field.

Validation after the repair:

  • go test -count=1 ./internal/sources ./examples ./internal/api/x/skills ./internal/service ./internal/registry
  • git diff --check
  • JSON parse confirmed the skill package has no ref and keeps the pinned commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant