Skip to content

Commit 0952cb2

Browse files
JAORMXclaude
andcommitted
Remove file path lists from component changes section
Implementation details like specific file paths belong in the implementation, not the RFC design document. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 841b886 commit 0952cb2

1 file changed

Lines changed: 5 additions & 33 deletions

File tree

rfcs/THV-0055-mcpserverentry-direct-remote-backends.md

Lines changed: 5 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -383,12 +383,6 @@ status:
383383

384384
##### Operator: New CRD and Controller
385385

386-
**New files:**
387-
- `cmd/thv-operator/api/v1alpha1/mcpserverentry_types.go` - CRD type
388-
definitions
389-
- `cmd/thv-operator/controllers/mcpserverentry_controller.go` -
390-
Validation-only controller
391-
392386
The MCPServerEntry controller is intentionally simple. It performs
393387
**validation only** and creates **no infrastructure**.
394388

@@ -419,10 +413,6 @@ The MCPGroup controller must be updated to watch MCPServerEntry resources
419413
in addition to MCPServer resources, so that `status.servers` and
420414
`status.serverCount` reflect both types of backends in the group.
421415

422-
**Files to modify:**
423-
- `cmd/thv-operator/controllers/mcpgroup_controller.go` - Add watch for
424-
MCPServerEntry, update status aggregation
425-
426416
##### Operator: VirtualMCPServer Controller Update
427417

428418
**Static mode (`outgoingAuth.source: inline`):** The operator generates
@@ -460,12 +450,6 @@ backends:
460450
# ...
461451
```
462452

463-
**Files to modify:**
464-
- `cmd/thv-operator/controllers/virtualmcpserver_controller.go` - Discover
465-
MCPServerEntry resources in group
466-
- `cmd/thv-operator/controllers/virtualmcpserver_vmcpconfig.go` - Include
467-
entry backends in ConfigMap generation
468-
469453
##### vMCP: Backend Type and Discovery
470454

471455
A new `BackendTypeEntry` constant (`"entry"`) is added to
@@ -504,12 +488,6 @@ For dynamic mode (`outgoingAuth.source: discovered`), the reconciler
504488
infrastructure from THV-0014 must be extended to watch MCPServerEntry
505489
resources.
506490

507-
**New files:**
508-
- `pkg/vmcp/k8s/mcpserverentry_watcher.go` - MCPServerEntry reconciler
509-
510-
**Files to modify:**
511-
- `pkg/vmcp/k8s/manager.go` - Register MCPServerEntry watcher
512-
513491
The `MCPServerEntryWatcher` follows the same reconciler pattern as the
514492
existing `MCPServerWatcher` from THV-0014. It holds a reference to the
515493
`DynamicRegistry` and the target `groupRef`. On reconciliation:
@@ -531,9 +509,6 @@ The static config parser must be updated to deserialize `type: entry`
531509
backends from the ConfigMap and create appropriate HTTP clients with
532510
external TLS support.
533511

534-
**Files to modify:**
535-
- `pkg/vmcp/config/` - Parse entry-type backends from static config
536-
537512
## Security Considerations
538513

539514
### Threat Model
@@ -738,12 +713,9 @@ MCPServerEntry is a purely additive change:
738713

739714
### Phase 1: CRD and Controller
740715

741-
1. Define `MCPServerEntry` types in
742-
`cmd/thv-operator/api/v1alpha1/mcpserverentry_types.go`
743-
2. Implement validation-only controller in
744-
`cmd/thv-operator/controllers/mcpserverentry_controller.go`
745-
3. Generate CRD manifests (`task operator-generate`,
746-
`task operator-manifests`)
716+
1. Define `MCPServerEntry` CRD types
717+
2. Implement validation-only controller
718+
3. Generate CRD manifests
747719
4. Update MCPGroup controller to watch MCPServerEntry resources
748720
5. Add unit tests for controller validation logic
749721

@@ -759,9 +731,9 @@ MCPServerEntry is a purely additive change:
759731

760732
### Phase 3: Dynamic Mode Integration
761733

762-
1. Create `MCPServerEntryWatcher` reconciler in `pkg/vmcp/k8s/`
734+
1. Create MCPServerEntry reconciler for vMCP's dynamic registry
763735
2. Register watcher in the K8s manager alongside MCPServerWatcher
764-
3. Update `ListWorkloadsInGroup()` to include MCPServerEntry
736+
3. Update workload discovery to include MCPServerEntry
765737
4. Resolve auth configs for entry backends at runtime
766738
5. Integration tests for dynamic discovery of entry backends
767739

0 commit comments

Comments
 (0)