Skip to content

Commit 12d0f5e

Browse files
JAORMXclaude
andcommitted
Remove Detailed Design section
Repository structure, package descriptions, and migration examples are implementation details that don't belong in an RFC. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent a2e3b84 commit 12d0f5e

1 file changed

Lines changed: 0 additions & 57 deletions

File tree

rfcs/THV-0032-toolhive-core-shared-library.md

Lines changed: 0 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -249,63 +249,6 @@ These packages are too coupled to ToolHive internals:
249249
| **ignore** | Hardcoded `.thvignore`, ToolHive paths |
250250
| **process** | Hardcoded paths, imports pkg/container/runtime |
251251

252-
### Detailed Design
253-
254-
#### Repository Structure
255-
256-
```
257-
github.com/stacklok/toolhive-core
258-
├── .github/
259-
│ ├── workflows/
260-
│ │ ├── ci.yml # Lint, test, coverage
261-
│ │ ├── release.yml # Automated releases
262-
│ │ └── dependabot.yml
263-
│ └── CODEOWNERS
264-
├── go.mod
265-
├── go.sum
266-
├── README.md
267-
├── CHANGELOG.md # Keep-a-changelog format
268-
├── CONTRIBUTING.md
269-
├── STABILITY.md # Stability level documentation
270-
└── [packages]/
271-
```
272-
273-
#### Package Descriptions
274-
275-
| Package | Purpose | Key Exports |
276-
|---------|---------|-------------|
277-
| **errors** | HTTP-aware error wrapping | `CodedError`, `WithCode()`, `Code()` |
278-
| **oauth** | RFC 8414/OIDC discovery types | `AuthorizationServerMetadata`, `OIDCDiscoveryDocument`, redirect validation |
279-
| **env** | Testable environment access | `Reader` interface, `OSReader` |
280-
| **permissions** | Container security profiles | `Profile`, `NetworkPermissions`, `MountDeclaration`, security validations |
281-
| **validation** | RFC 7230 HTTP validation | Header name/value validators, group name, resource URI |
282-
| **versions** | Build metadata | `VersionInfo`, `GetUserAgent()` |
283-
284-
#### Migration
285-
286-
Consuming projects update their `go.mod`:
287-
288-
```go
289-
module github.com/stacklok/toolhive
290-
291-
go 1.25
292-
293-
require (
294-
github.com/stacklok/toolhive-core v0.1.0
295-
// ... other dependencies
296-
)
297-
```
298-
299-
Import statements change:
300-
301-
```go
302-
// Before
303-
import "github.com/stacklok/toolhive/pkg/logger"
304-
305-
// After
306-
import "github.com/stacklok/toolhive-core/logger"
307-
```
308-
309252
## Security Considerations
310253

311254
### Threat Model

0 commit comments

Comments
 (0)