Skip to content

Commit 4c745de

Browse files
JAORMXclaude
andcommitted
Address review critical issues
- Fix test coverage to 70% (matching graduation criteria) - Remove detailed directory structure - Add toolhive-registry to Problem Statement repo list Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 12d0f5e commit 4c745de

1 file changed

Lines changed: 2 additions & 35 deletions

File tree

rfcs/THV-0032-toolhive-core-shared-library.md

Lines changed: 2 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ This RFC proposes creating a shared Go library (`toolhive-core`) to provide stab
1515

1616
The ToolHive ecosystem spans multiple Go repositories:
1717
- **toolhive** - Core runtime, CLI, operator, proxy-runner, virtual MCP
18+
- **toolhive-registry** - Registry data and CLI tools
1819
- **toolhive-registry-server** - Registry API server
1920
- **dockyard** - Container packaging for MCP servers
2021

@@ -180,40 +181,6 @@ These packages meet all graduation criteria (zero ToolHive-specific coupling, we
180181

181182
> **Note**: All packages start as Beta in v0.x releases. Once the library reaches v1.0.0, packages meeting all graduation criteria will be promoted to Stable.
182183
183-
**Proposed `toolhive-core` structure:**
184-
185-
```
186-
toolhive-core/
187-
├── go.mod
188-
├── go.sum
189-
├── README.md
190-
├── CHANGELOG.md
191-
├── errors/
192-
│ ├── errors.go # CodedError, WithCode, Code()
193-
│ ├── errors_test.go
194-
│ └── doc.go
195-
├── oauth/
196-
│ ├── oauth.go # AuthorizationServerMetadata, OIDCDiscoveryDocument
197-
│ ├── oauth_test.go
198-
│ └── doc.go
199-
├── env/
200-
│ ├── env.go # Reader interface, OSReader
201-
│ ├── env_test.go
202-
│ └── doc.go
203-
├── permissions/
204-
│ ├── profile.go # Profile, NetworkPermissions, MountDeclaration
205-
│ ├── profile_test.go
206-
│ └── doc.go
207-
├── validation/
208-
│ ├── validation.go # HTTP header, URI, group name validators
209-
│ ├── validation_test.go
210-
│ └── doc.go
211-
└── versions/
212-
├── version.go # VersionInfo, GetUserAgent
213-
├── version_test.go
214-
└── doc.go
215-
```
216-
217184
#### Tier 2: Minor Refactoring Required
218185

219186
These packages have solid implementations but need minor changes to remove ToolHive-specific coupling:
@@ -315,7 +282,7 @@ These packages are too coupled to ToolHive internals:
315282

316283
### Unit Tests
317284

318-
- All packages must have ≥80% coverage
285+
- All packages must have ≥70% coverage
319286
- Table-driven tests for validation functions
320287
- Mock-based tests for interface implementations
321288

0 commit comments

Comments
 (0)