Skip to content

Commit a2e3b84

Browse files
JAORMXclaude
andcommitted
Remove Implementation Plan section
Arbitrary timelines and obvious phases don't add value to the RFC. Implementation details will be figured out during implementation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent b7b9441 commit a2e3b84

1 file changed

Lines changed: 0 additions & 37 deletions

File tree

rfcs/THV-0032-toolhive-core-shared-library.md

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -368,43 +368,6 @@ import "github.com/stacklok/toolhive-core/logger"
368368
- **Optional features**: New features use functional options pattern
369369
- **Version constraints**: Consumers can pin to major versions for stability
370370

371-
## Implementation Plan
372-
373-
### Phase 1: Repository Setup (Week 1-2)
374-
375-
- Create `stacklok/toolhive-core` repository
376-
- Set up CI/CD (linting, testing, release automation)
377-
- Establish CODEOWNERS and contribution guidelines
378-
- Document graduation criteria in STABILITY.md
379-
380-
### Phase 2: Initial Package Migration (Week 3-4)
381-
382-
- Extract Tier 1 packages: errors, oauth, env, permissions, validation, versions
383-
- Ensure 100% test parity with original implementations
384-
- Write package documentation and examples
385-
- Tag v0.1.0 release
386-
387-
### Phase 3: Consumer Migration (Week 5-8)
388-
389-
- Update `toolhive` to import from `toolhive-core`
390-
- Update `dockyard` to import from `toolhive-core` (currently imports `pkg/logger`, `pkg/container/images`, `pkg/runner`)
391-
- Update `toolhive-registry` to import from `toolhive-core` (currently imports `pkg/logger`, `pkg/permissions`, `pkg/registry/*`)
392-
- Offer `toolhive-registry-server` the option to adopt toolhive-core (may choose to continue with slog)
393-
- Deprecate original packages with forwarding imports
394-
- Monitor for issues and release patches as needed
395-
396-
### Phase 4: Tier 2 Evaluation (Ongoing)
397-
398-
- Evaluate secrets, auth/oauth, transport/types for graduation
399-
- Create graduation RFCs for approved packages
400-
- Release minor versions with new packages
401-
402-
### Dependencies
403-
404-
- Go 1.25+ (matching minimum version across toolhive ecosystem)
405-
- GitHub Actions for CI/CD
406-
- goreleaser for release automation
407-
408371
## Testing Strategy
409372

410373
### Unit Tests

0 commit comments

Comments
 (0)