RFC: ToolHive Core Shared Library with Package Graduation Criteria#32
Merged
Conversation
JAORMX
force-pushed
the
rfc/toolhive-core-shared-library
branch
2 times, most recently
from
4c745de to
ae07bb2
Compare
Proposes creating toolhive-core, a shared Go library with explicit API stability guarantees for the ToolHive ecosystem. Establishes formal graduation criteria for promoting packages from internal to shared status. Key points: - Graduation criteria: stability, quality, dependencies, governance - Tier 1 packages: logger, errors, validation, healthcheck, versions, env - Based on actual exploration of toolhive, toolhive-registry-server, dockyard
JAORMX
force-pushed
the
rfc/toolhive-core-shared-library
branch
from
ae07bb2 to
cb55ce2
Compare
jhrozek
previously approved these changes
Jan 29, 2026
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
I think this is a good proposal. We'll only have more projects.
rdimitrov
previously approved these changes
Jan 29, 2026
jerm-dro
reviewed
Jan 29, 2026
- Add note clarifying operator independence is out of scope (RunConfig format stability would need separate consideration) - Add future sharing opportunities: pkg/oauth refactoring, pkg/networking patterns (HTTP builder, endpoint validation) - Add guiding principle about packages being genuinely reusable - Add pkg/recovery to Tier 1 immediate graduation candidates - Add auth/metadata to Tier 2 for protected resource metadata extraction - Add registry/types, container/verifier, and cache to Tier 3 - Add cache consolidation opportunity note Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rdimitrov
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposes creating
toolhive-core, a shared Go library with explicit API stability guarantees for the ToolHive ecosystem. Establishes formal graduation criteria for promoting packages from internal to shared status.Key Points
Problem Addressed
pkg/logger,pkg/container/images,pkg/runner) with no stability guaranteesOpen Questions
🤖 Generated with Claude Code