THV-0023: Remove configMapRef from MCPOIDCConfig#64
Merged
ChrisJBurns merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
Since MCPOIDCConfig is a dedicated typed CRD, there is no need for a configMapRef indirection — the type's own fields should always be used inline. This simplifies the CEL union to just kubernetesServiceAccount or inline. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JAORMX
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configMapRefvariant fromMCPOIDCConfigsince the CRD itself is a dedicated typed resource — its fields should always be specified inline rather than via ConfigMap indirectionkubernetesServiceAccountorinline)Test plan
configMapRefin MCPOIDCConfig context are removedconfigMapRefis intentionally preserved (authz policies from ConfigMap is a distinct use case)🤖 Generated with Claude Code