fix(skills): raise registry card Install button above navigation overlay#2098
Merged
fix(skills): raise registry card Install button above navigation overlay#2098
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an interaction bug in the Skills “Registry” tab where the card-level navigation overlay was intercepting clicks intended for the Install button, preventing the install dialog from opening.
Changes:
- Raise the Registry card Install button above the full-card navigation overlay by adding
relative z-10to its class list.
peppescg
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Skills > Registry tab, clicking Install on a card would navigate to the skill detail page instead of opening the install dialog. The Local Builds and Installed tabs were unaffected.
Root cause
card-skill-base.tsxrenders a full-card click overlay — an absolutely-positioned<span>pinned toinset-0inside the title button — to make the whole card a navigation target. Because the overlay is absolutely positioned against therelativeCard, it stacks above any statically-positioned descendant, including footer buttons. Siblings in the footer have to opt into their own stacking context (position: relative+ az-index) to receive their own clicks, otherwise the overlay captures the pointer and the card-levelonClickruns instead.Every other action button in the Skills cards already does this:
card-build.tsx— Install and Remove userelative z-10.card-skill.tsx— Uninstall usesrelative z-10.card-registry-skill.tsx— the sibling GitHub link usesrelative z-10.The Install button in
card-registry-skill.tsxwas the only one missing the escape hatch, so the overlay kept eating its clicks. The existinge.stopPropagation()on the handler was correct but never fired — the event never reached the button in the first place.Changes
card-registry-skill.tsx: addrelative z-10to the Install button's class list, matching the pattern used on the other Skills cards.No logic, analytics, or markup changes beyond the class tweak.
Verification
card-registry-skill.test.tsx—opens the install dialog when Install button is clickedanddoes not navigate when Install button is clicked— continue to pass; they exercise theonClickpath via userEvent and are unaffected by the z-index fix.