ci(release): disable pnpm 11 verifyDepsBeforeRun to fix ubuntu-arm hang#2290
Merged
Conversation
Forward-port (the applicable half) of stacklok/stacklok-enterprise-platform#1243 to OSS. The Node 24.15.0 pin from that PR is already in `.github/actions/setup`, but the `verifyDepsBeforeRun: false` half is not — and OSS reproduces every precondition of the regression Luis resolved on the enterprise overlay: - `ubuntu-24.04-arm` runner in `_build-matrix.yml`, `pr-build-test.yml`, `on-release.yml` - pnpm 11.1.2 (default `verifyDepsBeforeRun=true`) - `npm version` mutates `package.json` before `pnpm run publish` / `pnpm run make`, which makes pnpm 11 trigger a second install pass that re-resolves overrides and reruns `postinstall: electron-rebuild` - overrides moved to `pnpm-workspace.yaml` (upstream PR #2239) The recent release history matches Luis's documented fingerprint exactly — v0.35.0-rc.0, v0.35.0-rc.1, v0.35.1-rc.0, v0.35.1, v0.35.3-rc.0, v0.35.3-rc.1 all cancelled or failed on arm. v0.34.x ran on pnpm 10.33.0 (no such setting) and shipped arm cleanly every time. Setting `verifyDepsBeforeRun: false` skips the second install pass while keeping pnpm 11.1.2 (so workspace-level overrides still apply correctly). Refs: nodejs/node#62253, npm/cli#9118, stacklok/stacklok-enterprise-platform#1243
Contributor
There was a problem hiding this comment.
Pull request overview
Disables pnpm 11’s verify-deps-before-run behavior at the workspace level to prevent CI hangs on ubuntu-24.04-arm when package.json is mutated (e.g., by npm version) and a subsequent pnpm run would otherwise trigger pnpm’s extra verification/install pass.
Changes:
- Set
verifyDepsBeforeRun: falseinpnpm-workspace.yaml. - Added inline documentation explaining the CI hang scenario and why the setting is needed.
reyortiz3
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-ports the applicable half of stacklok/stacklok-enterprise-platform#1243 (by @lujunsan) to OSS. The Node 24.15.0 pin from that PR is already in
.github/actions/setup/action.yaml, but theverifyDepsBeforeRun: falsehalf is not — and OSS reproduces every precondition of the regression resolved on the enterprise overlay.The bug
ubuntu-24.04-armrunner_build-matrix.yml:15,pr-build-test.yml:150,on-release.yml:83verifyDepsBeforeRun=true)actions/setup/action.yaml:9npm versionmutatespackage.jsonbeforepnpm run Xon-release.yml:111→pnpm run publish:170;pr-build-test.yml:187pnpm-workspace.yaml(PR #2239)verifyDepsBeforeRununset (defaults totrueon pnpm 11)The
npm versionstep mutatespackage.json. The nextpnpm run publishthen triggers pnpm 11'sverify-deps-before-runsecond install pass — re-resolves overrides, prunes transitive packages, rerunspostinstall: electron-rebuild. Onubuntu-24.04-armthat second pass hangs at end-of-install ~90% of the time in interruptible sleep at ~600MB RSS, blocking the job for 30+ min.Evidence in OSS release history
Matches the fingerprint exactly:
v0.35.x is where this started — pnpm 11.1.2 landed via upstream PR #2239 (2026-05-13), which also moved overrides into
pnpm-workspace.yaml.The fix
Single line in
pnpm-workspace.yaml:```yaml
verifyDepsBeforeRun: false
```
Skips the second install pass while keeping pnpm 11.1.2 (so workspace-level overrides still apply correctly). Idempotent on local dev — first `pnpm install` is unaffected; only the pre-script consistency check is dropped.
Why this differs from the enterprise PR
Enterprise vendors studio as a submodule and mutates `pnpm-workspace.yaml` at job-time via `yq -i` (so the mutation lives only during the release job). OSS owns the file, so we set it directly — same effect, simpler.
Test plan
References
🤖 Generated with Claude Code