Support all sentinel for multi-client skill install

Author: samuv

cmd/thv/app/skill_install.go

@@ -37,7 +37,7 @@ func init() {
 	skillCmd.AddCommand(skillInstallCmd)
 
 	skillInstallCmd.Flags().StringVar(&skillInstallClientsRaw, "clients", "",
-		"Comma-separated target client apps (e.g. claude-code,opencode)")
+		`Comma-separated target client apps (e.g. claude-code,opencode), or "all" for every available client`)
 	skillInstallCmd.Flags().StringVar(&skillInstallScope, "scope", string(skills.ScopeUser), "Installation scope (user, project)")
 	skillInstallCmd.Flags().BoolVar(&skillInstallForce, "force", false, "Overwrite existing skill directory")
 	skillInstallCmd.Flags().StringVar(&skillInstallProjectRoot, "project-root", "", "Project root path for project-scoped installs")

docs/cli/thv_skill_install.md

@@ -25,7 +25,9 @@ type installSkillRequest struct {
 	Scope skills.Scope `json:"scope,omitempty"`
 	// ProjectRoot is the project root path for project-scoped installs
 	ProjectRoot string `json:"project_root,omitempty"`
-	// Clients lists target client identifiers (e.g., "claude-code"). Omit for default client.
+	// Clients lists target client identifiers (e.g., "claude-code"),
+	// or ["all"] to target every skill-supporting client.
+	// Omitting this field installs to all available clients.
 	Clients []string `json:"clients,omitempty"`
 	// Force allows overwriting unmanaged skill directories
 	Force bool `json:"force,omitempty"`

docs/server/docs.go

@@ -1197,9 +1197,12 @@ func (s *service) extractOCIContent(ctx context.Context, d digest.Digest) ([]byt
 	return layerData, skillConfig, nil
 }
 
+// clientsAllSentinel is the reserved value that expands to all skill-supporting clients.
+const clientsAllSentinel = "all"
+
 // resolveAndValidateClients returns the deduplicated client list and a map of
-// client identifier to install directory. Empty opts.Clients means the first
-// skill-supporting client from the path resolver.
+// client identifier to install directory. Empty opts.Clients (or the sentinel
+// value "all") expands to every skill-supporting client returned by the path resolver.
 func (s *service) resolveAndValidateClients(
 	opts skills.InstallOptions,
 	skillName string,
@@ -1214,23 +1217,30 @@ func (s *service) resolveAndValidateClients(
 	}
 
 	var requested []string
-	if len(opts.Clients) == 0 {
+	switch {
+	case len(opts.Clients) == 0 || (len(opts.Clients) == 1 && strings.EqualFold(opts.Clients[0], clientsAllSentinel)):
 		clients := s.pathResolver.ListSkillSupportingClients()
 		if len(clients) == 0 {
 			return nil, nil, httperr.WithCode(
 				errors.New("no skill-supporting clients configured"),
 				http.StatusInternalServerError,
 			)
 		}
-		requested = []string{clients[0]}
-	} else {
+		requested = clients
+	default:
 		for _, c := range opts.Clients {
 			if c == "" {
 				return nil, nil, httperr.WithCode(
 					errors.New("clients entries must be non-empty strings"),
 					http.StatusBadRequest,
 				)
 			}
+			if strings.EqualFold(c, clientsAllSentinel) {
+				return nil, nil, httperr.WithCode(
+					fmt.Errorf("%q cannot be combined with other client names", clientsAllSentinel),
+					http.StatusBadRequest,
+				)
+			}
 		}
 		requested = dedupeStringsPreserveOrder(opts.Clients)
 	}

docs/server/swagger.json

@@ -483,6 +483,54 @@ func TestInstallWithExtraction(t *testing.T) {
 		assert.Equal(t, http.StatusBadRequest, httperr.Code(err))
 	})
 
+	t.Run("clients all sentinel expands to every skill-supporting client", func(t *testing.T) {
+		t.Parallel()
+		ctrl := gomock.NewController(t)
+		store := storemocks.NewMockSkillStore(ctrl)
+		pr := skillsmocks.NewMockPathResolver(ctrl)
+		inst := skillsmocks.NewMockInstaller(ctrl)
+
+		dirA := filepath.Join(t.TempDir(), "a", "my-skill")
+		dirB := filepath.Join(t.TempDir(), "b", "my-skill")
+		pr.EXPECT().ListSkillSupportingClients().Return([]string{"claude-code", "opencode"})
+		pr.EXPECT().GetSkillPath("claude-code", "my-skill", skills.ScopeUser, "").Return(dirA, nil)
+		pr.EXPECT().GetSkillPath("opencode", "my-skill", skills.ScopeUser, "").Return(dirB, nil)
+		store.EXPECT().Get(gomock.Any(), "my-skill", skills.ScopeUser, "").Return(skills.InstalledSkill{}, storage.ErrNotFound)
+		inst.EXPECT().Extract(layerData, dirA, false).Return(&skills.ExtractResult{SkillDir: dirA, Files: 1}, nil)
+		inst.EXPECT().Extract(layerData, dirB, false).Return(&skills.ExtractResult{SkillDir: dirB, Files: 1}, nil)
+		store.EXPECT().Create(gomock.Any(), gomock.Any()).DoAndReturn(
+			func(_ context.Context, sk skills.InstalledSkill) error {
+				assert.ElementsMatch(t, []string{"claude-code", "opencode"}, sk.Clients)
+				return nil
+			})
+
+		svc := New(store, WithPathResolver(pr), WithInstaller(inst))
+		_, err := svc.Install(t.Context(), skills.InstallOptions{
+			Name:      "my-skill",
+			LayerData: layerData,
+			Digest:    "sha256:abc",
+			Clients:   []string{"all"},
+		})
+		require.NoError(t, err)
+	})
+
+	t.Run("all sentinel mixed with named client returns bad request", func(t *testing.T) {
+		t.Parallel()
+		ctrl := gomock.NewController(t)
+		store := storemocks.NewMockSkillStore(ctrl)
+		pr := skillsmocks.NewMockPathResolver(ctrl)
+
+		svc := New(store, WithPathResolver(pr))
+		_, err := svc.Install(t.Context(), skills.InstallOptions{
+			Name:      "my-skill",
+			LayerData: layerData,
+			Digest:    "sha256:abc",
+			Clients:   []string{"all", "opencode"},
+		})
+		require.Error(t, err)
+		assert.Equal(t, http.StatusBadRequest, httperr.Code(err))
+	})
+
 	t.Run("fresh install rolls back extraction on store.Create failure", func(t *testing.T) {
 		t.Parallel()
 		ctrl := gomock.NewController(t)