Commit 0fb1b42
authored
Isolate
The subtests failed when `TOOLHIVE_DEV=true` was set in the shell
environment. `isDevMode()` reads that variable, causing the function to
use `http://` instead of `https://` and to skip SSRF rejection -- the
opposite of what the non-dev test cases assert.
Fix: remove `t.Parallel()` from `TestParseGitReference` and add
`t.Setenv("TOOLHIVE_DEV", "")` so the test always runs in a clean
environment, matching the pattern used by `TestParseGitReferenceDevMode`.TestParseGitReference from ambient env (#4813)1 parent 1fa05ee commit 0fb1b42
1 file changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
38 | 39 | | |
39 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
40 | 44 | | |
41 | 45 | | |
42 | 46 | | |
| |||
159 | 163 | | |
160 | 164 | | |
161 | 165 | | |
162 | | - | |
163 | 166 | | |
164 | 167 | | |
165 | 168 | | |
| |||
0 commit comments