Skip to content

Commit 2323cd1

Browse files
committed
fixes from review
1 parent 18b17d1 commit 2323cd1

4 files changed

Lines changed: 368 additions & 397 deletions

File tree

pkg/vmcp/cli/embedding_manager_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ func TestNewEmbeddingServiceManager_DefaultImage(t *testing.T) {
108108
Model: "BAAI/bge-small-en-v1.5",
109109
})
110110
require.NoError(t, err)
111-
assert.Equal(t, defaultTEIImage, mgr.cfg.Image)
111+
assert.Equal(t, DefaultEmbeddingImage, mgr.cfg.Image)
112112
assert.Equal(t, containerNameForModel("BAAI/bge-small-en-v1.5"), mgr.containerName)
113113
}
114114

@@ -198,7 +198,7 @@ func TestStart_DeployNewContainer(t *testing.T) {
198198
mockRT.EXPECT().IsWorkloadRunning(gomock.Any(), mgr.containerName).Return(false, nil)
199199
mockRT.EXPECT().DeployWorkload(
200200
gomock.Any(),
201-
defaultTEIImage,
201+
DefaultEmbeddingImage,
202202
mgr.containerName,
203203
[]string{"--model-id", "BAAI/bge-small-en-v1.5"},
204204
gomock.Nil(),
@@ -247,7 +247,7 @@ func TestStart_DeployNewContainer_Kubernetes(t *testing.T) {
247247
mockRT.EXPECT().IsWorkloadRunning(gomock.Any(), mgr.containerName).Return(false, nil)
248248
mockRT.EXPECT().DeployWorkload(
249249
gomock.Any(),
250-
defaultTEIImage,
250+
DefaultEmbeddingImage,
251251
mgr.containerName,
252252
[]string{"--model-id", "BAAI/bge-small-en-v1.5"},
253253
gomock.Nil(), // no env vars

0 commit comments

Comments
 (0)