fix lint

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>

Author: jerm-dro

cmd/thv-operator/api/v1alpha1/virtualmcpserver_types.go

@@ -1,9 +1,10 @@
 package v1alpha1
 
 import (
-	"github.com/stacklok/toolhive/pkg/telemetry"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
+
+	"github.com/stacklok/toolhive/pkg/telemetry"
 )
 
 // VirtualMCPServerSpec defines the desired state of VirtualMCPServer

pkg/vmcp/server/server.go

@@ -204,7 +204,13 @@ func New(
 	// backend calls are instrumented when they occur during workflow execution.
 	if cfg.TelemetryProvider != nil {
 		var err error
-		backendClient, err = monitorBackends(context.Background(), cfg.TelemetryProvider.MeterProvider(), cfg.TelemetryProvider.TracerProvider(), backends, backendClient)
+		backendClient, err = monitorBackends(
+			context.Background(),
+			cfg.TelemetryProvider.MeterProvider(),
+			cfg.TelemetryProvider.TracerProvider(),
+			backends,
+			backendClient,
+		)
 		if err != nil {
 			return nil, fmt.Errorf("failed to monitor backends: %w", err)
 		}
@@ -224,7 +230,11 @@ func New(
 
 	// Decorate workflow executors with telemetry if provider is configured
 	if cfg.TelemetryProvider != nil {
-		workflowExecutors, err = monitorWorkflowExecutors(cfg.TelemetryProvider.MeterProvider(), cfg.TelemetryProvider.TracerProvider(), workflowExecutors)
+		workflowExecutors, err = monitorWorkflowExecutors(
+			cfg.TelemetryProvider.MeterProvider(),
+			cfg.TelemetryProvider.TracerProvider(),
+			workflowExecutors,
+		)
 		if err != nil {
 			return nil, fmt.Errorf("failed to monitor workflow executors: %w", err)
 		}

pkg/vmcp/server/telemetry.go

@@ -38,15 +38,24 @@ func monitorBackends(
 	}
 	backendCount.Record(ctx, int64(len(backends)))
 
-	requestsTotal, err := meter.Int64Counter("toolhive_vmcp_backend_requests_total", metric.WithDescription("Total number of requests per backend"))
+	requestsTotal, err := meter.Int64Counter(
+		"toolhive_vmcp_backend_requests_total",
+		metric.WithDescription("Total number of requests per backend"),
+	)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create requests total counter: %w", err)
 	}
-	errorsTotal, err := meter.Int64Counter("toolhive_vmcp_backend_errors_total", metric.WithDescription("Total number of errors per backend"))
+	errorsTotal, err := meter.Int64Counter(
+		"toolhive_vmcp_backend_errors_total",
+		metric.WithDescription("Total number of errors per backend"),
+	)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create errors total counter: %w", err)
 	}
-	requestsDuration, err := meter.Float64Histogram("toolhive_vmcp_backend_requests_duration", metric.WithDescription("Duration of requests in seconds per backend"))
+	requestsDuration, err := meter.Float64Histogram(
+		"toolhive_vmcp_backend_requests_duration",
+		metric.WithDescription("Duration of requests in seconds per backend"),
+	)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create requests duration histogram: %w", err)
 	}
@@ -73,7 +82,9 @@ var _ vmcp.BackendClient = telemetryBackendClient{}
 
 // record updates the metrics and creates a span for each method on the BackendClient interface.
 // It returns a function that should be deferred to record the duration, error, and end the span.
-func (t telemetryBackendClient) record(ctx context.Context, target *vmcp.BackendTarget, action string, err *error) (context.Context, func()) {
+func (t telemetryBackendClient) record(
+	ctx context.Context, target *vmcp.BackendTarget, action string, err *error,
+) (context.Context, func()) {
 	// Create span attributes
 	commonAttrs := []attribute.KeyValue{
 		attribute.String("target.workload_id", target.WorkloadID),
@@ -104,25 +115,33 @@ func (t telemetryBackendClient) record(ctx context.Context, target *vmcp.Backend
 	}
 }
 
-func (t telemetryBackendClient) CallTool(ctx context.Context, target *vmcp.BackendTarget, toolName string, arguments map[string]any) (_ map[string]any, retErr error) {
+func (t telemetryBackendClient) CallTool(
+	ctx context.Context, target *vmcp.BackendTarget, toolName string, arguments map[string]any,
+) (_ map[string]any, retErr error) {
 	ctx, done := t.record(ctx, target, "call_tool", &retErr)
 	defer done()
 	return t.backendClient.CallTool(ctx, target, toolName, arguments)
 }
 
-func (t telemetryBackendClient) ReadResource(ctx context.Context, target *vmcp.BackendTarget, uri string) (_ []byte, retErr error) {
+func (t telemetryBackendClient) ReadResource(
+	ctx context.Context, target *vmcp.BackendTarget, uri string,
+) (_ []byte, retErr error) {
 	ctx, done := t.record(ctx, target, "read_resource", &retErr)
 	defer done()
 	return t.backendClient.ReadResource(ctx, target, uri)
 }
 
-func (t telemetryBackendClient) GetPrompt(ctx context.Context, target *vmcp.BackendTarget, name string, arguments map[string]any) (_ string, retErr error) {
+func (t telemetryBackendClient) GetPrompt(
+	ctx context.Context, target *vmcp.BackendTarget, name string, arguments map[string]any,
+) (_ string, retErr error) {
 	ctx, done := t.record(ctx, target, "get_prompt", &retErr)
 	defer done()
 	return t.backendClient.GetPrompt(ctx, target, name, arguments)
 }
 
-func (t telemetryBackendClient) ListCapabilities(ctx context.Context, target *vmcp.BackendTarget) (_ *vmcp.CapabilityList, retErr error) {
+func (t telemetryBackendClient) ListCapabilities(
+	ctx context.Context, target *vmcp.BackendTarget,
+) (_ *vmcp.CapabilityList, retErr error) {
 	ctx, done := t.record(ctx, target, "list_capabilities", &retErr)
 	defer done()
 	return t.backendClient.ListCapabilities(ctx, target)

test/integration/vmcp/vmcp_integration_test.go

@@ -237,7 +237,10 @@ func TestVMCPServer_TwoBoundaryAuth_HeaderInjection(t *testing.T) {
 // Prometheus metrics for composite tool workflow executions and backend requests on /metrics.
 // This test creates a composite tool, executes it, and verifies the metrics
 // for both the workflow and the backend subtool calls are correctly exposed.
+//
+//nolint:paralleltest // safe to run in parallel with other tests
 func TestVMCPServer_Telemetry_CompositeToolMetrics(t *testing.T) {
+	t.Parallel()
 
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()