Skip to content

Commit 374d452

Browse files
authored
Fixed VirtualMCPCompositeToolDefinition printer columns output (#5380)
* Fixed VirtualMCPCompositeToolDefinition printer columns output Signed-off-by: Sanskarzz <sanskar.gur@gmail.com> * Improved coverage and fixed CI lint error Signed-off-by: Sanskarzz <sanskar.gur@gmail.com> * Fixed Operator E2E CI failures Signed-off-by: Sanskarzz <sanskar.gur@gmail.com> * removed malformed Steps and Refs printer column Signed-off-by: Sanskarzz <sanskar.gur@gmail.com> --------- Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
1 parent 8932f93 commit 374d452

4 files changed

Lines changed: 0 additions & 36 deletions

File tree

cmd/thv-operator/api/v1alpha1/types.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,9 +339,7 @@ type MCPToolConfigList struct {
339339
//+kubebuilder:subresource:status
340340
//+kubebuilder:resource:shortName=vmcpctd;compositetool,categories=toolhive
341341
//+kubebuilder:printcolumn:name="Workflow",type="string",JSONPath=".spec.name",description="Workflow name"
342-
//+kubebuilder:printcolumn:name="Steps",type="integer",JSONPath=".spec.steps[*]",description="Number of steps"
343342
//+kubebuilder:printcolumn:name="Status",type="string",JSONPath=".status.validationStatus",description="Validation status"
344-
//+kubebuilder:printcolumn:name="Refs",type="integer",JSONPath=".status.referencingVirtualServers[*]",description="Refs"
345343
//+kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Age"
346344
//+kubebuilder:printcolumn:name="Ready",type="string",JSONPath=".status.conditions[?(@.type=='Ready')].status"
347345

cmd/thv-operator/api/v1beta1/virtualmcpcompositetooldefinition_types.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,7 @@ const (
102102
//+kubebuilder:subresource:status
103103
//+kubebuilder:resource:shortName=vmcpctd;compositetool,categories=toolhive
104104
//+kubebuilder:printcolumn:name="Workflow",type="string",JSONPath=".spec.name",description="Workflow name"
105-
//+kubebuilder:printcolumn:name="Steps",type="integer",JSONPath=".spec.steps[*]",description="Number of steps"
106105
//+kubebuilder:printcolumn:name="Status",type="string",JSONPath=".status.validationStatus",description="Validation status"
107-
//+kubebuilder:printcolumn:name="Refs",type="integer",JSONPath=".status.referencingVirtualServers[*]",description="Refs"
108106
//+kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Age"
109107
//+kubebuilder:printcolumn:name="Ready",type="string",JSONPath=".status.conditions[?(@.type=='Ready')].status"
110108

deploy/charts/operator-crds/files/crds/toolhive.stacklok.dev_virtualmcpcompositetooldefinitions.yaml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,10 @@ spec:
2424
jsonPath: .spec.name
2525
name: Workflow
2626
type: string
27-
- description: Number of steps
28-
jsonPath: .spec.steps[*]
29-
name: Steps
30-
type: integer
3127
- description: Validation status
3228
jsonPath: .status.validationStatus
3329
name: Status
3430
type: string
35-
- description: Refs
36-
jsonPath: .status.referencingVirtualServers[*]
37-
name: Refs
38-
type: integer
3931
- description: Age
4032
jsonPath: .metadata.creationTimestamp
4133
name: Age
@@ -431,18 +423,10 @@ spec:
431423
jsonPath: .spec.name
432424
name: Workflow
433425
type: string
434-
- description: Number of steps
435-
jsonPath: .spec.steps[*]
436-
name: Steps
437-
type: integer
438426
- description: Validation status
439427
jsonPath: .status.validationStatus
440428
name: Status
441429
type: string
442-
- description: Refs
443-
jsonPath: .status.referencingVirtualServers[*]
444-
name: Refs
445-
type: integer
446430
- description: Age
447431
jsonPath: .metadata.creationTimestamp
448432
name: Age

deploy/charts/operator-crds/templates/toolhive.stacklok.dev_virtualmcpcompositetooldefinitions.yaml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,10 @@ spec:
2727
jsonPath: .spec.name
2828
name: Workflow
2929
type: string
30-
- description: Number of steps
31-
jsonPath: .spec.steps[*]
32-
name: Steps
33-
type: integer
3430
- description: Validation status
3531
jsonPath: .status.validationStatus
3632
name: Status
3733
type: string
38-
- description: Refs
39-
jsonPath: .status.referencingVirtualServers[*]
40-
name: Refs
41-
type: integer
4234
- description: Age
4335
jsonPath: .metadata.creationTimestamp
4436
name: Age
@@ -434,18 +426,10 @@ spec:
434426
jsonPath: .spec.name
435427
name: Workflow
436428
type: string
437-
- description: Number of steps
438-
jsonPath: .spec.steps[*]
439-
name: Steps
440-
type: integer
441429
- description: Validation status
442430
jsonPath: .status.validationStatus
443431
name: Status
444432
type: string
445-
- description: Refs
446-
jsonPath: .status.referencingVirtualServers[*]
447-
name: Refs
448-
type: integer
449433
- description: Age
450434
jsonPath: .metadata.creationTimestamp
451435
name: Age

0 commit comments

Comments
 (0)