Skip to content

Commit c3de018

Browse files
ChrisJBurnsclaude
andcommitted
Use WorkloadKindMCPRemoteProxy constant instead of string literal
Replace hardcoded "MCPRemoteProxy" strings with the shared constant from PR #4520 for consistency with all other controllers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 500ab99 commit c3de018

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

cmd/thv-operator/controllers/mcpremoteproxy_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ func (r *MCPRemoteProxyReconciler) updateOIDCConfigReferencingWorkloads(
820820
proxyName string,
821821
) error {
822822
ref := mcpv1alpha1.WorkloadReference{
823-
Kind: "MCPRemoteProxy",
823+
Kind: mcpv1alpha1.WorkloadKindMCPRemoteProxy,
824824
Name: proxyName,
825825
}
826826

cmd/thv-operator/test-integration/mcp-oidc-config/mcpoidcconfig_mcpremoteproxy_integration_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ var _ = Describe("MCPOIDCConfig and MCPRemoteProxy Cross-Resource Integration Te
168168
if err != nil {
169169
return false
170170
}
171-
expectedRef := mcpv1alpha1.WorkloadReference{Kind: "MCPRemoteProxy", Name: proxyName}
171+
expectedRef := mcpv1alpha1.WorkloadReference{Kind: mcpv1alpha1.WorkloadKindMCPRemoteProxy, Name: proxyName}
172172
for _, ref := range updated.Status.ReferencingWorkloads {
173173
if ref == expectedRef {
174174
return true
@@ -522,7 +522,7 @@ var _ = Describe("MCPOIDCConfig and MCPRemoteProxy Cross-Resource Integration Te
522522
if err != nil {
523523
return false
524524
}
525-
expectedRef := mcpv1alpha1.WorkloadReference{Kind: "MCPRemoteProxy", Name: proxyName}
525+
expectedRef := mcpv1alpha1.WorkloadReference{Kind: mcpv1alpha1.WorkloadKindMCPRemoteProxy, Name: proxyName}
526526
for _, ref := range updated.Status.ReferencingWorkloads {
527527
if ref == expectedRef {
528528
return true
@@ -657,7 +657,7 @@ var _ = Describe("MCPOIDCConfig and MCPRemoteProxy Cross-Resource Integration Te
657657
if err != nil {
658658
return false
659659
}
660-
expectedRef := mcpv1alpha1.WorkloadReference{Kind: "MCPRemoteProxy", Name: proxyName}
660+
expectedRef := mcpv1alpha1.WorkloadReference{Kind: mcpv1alpha1.WorkloadKindMCPRemoteProxy, Name: proxyName}
661661
for _, ref := range updated.Status.ReferencingWorkloads {
662662
if ref == expectedRef {
663663
return true
@@ -707,7 +707,7 @@ var _ = Describe("MCPOIDCConfig and MCPRemoteProxy Cross-Resource Integration Te
707707
if err != nil {
708708
return false
709709
}
710-
expectedRef := mcpv1alpha1.WorkloadReference{Kind: "MCPRemoteProxy", Name: proxyName}
710+
expectedRef := mcpv1alpha1.WorkloadReference{Kind: mcpv1alpha1.WorkloadKindMCPRemoteProxy, Name: proxyName}
711711
for _, ref := range cfg.Status.ReferencingWorkloads {
712712
if ref == expectedRef {
713713
return false
@@ -801,7 +801,7 @@ var _ = Describe("MCPOIDCConfig and MCPRemoteProxy Cross-Resource Integration Te
801801
if err != nil {
802802
return false
803803
}
804-
expectedRef := mcpv1alpha1.WorkloadReference{Kind: "MCPRemoteProxy", Name: proxyName}
804+
expectedRef := mcpv1alpha1.WorkloadReference{Kind: mcpv1alpha1.WorkloadKindMCPRemoteProxy, Name: proxyName}
805805
for _, ref := range updated.Status.ReferencingWorkloads {
806806
if ref == expectedRef {
807807
return true
@@ -830,7 +830,7 @@ var _ = Describe("MCPOIDCConfig and MCPRemoteProxy Cross-Resource Integration Te
830830
if err != nil {
831831
return false
832832
}
833-
expectedRef := mcpv1alpha1.WorkloadReference{Kind: "MCPRemoteProxy", Name: proxyName}
833+
expectedRef := mcpv1alpha1.WorkloadReference{Kind: mcpv1alpha1.WorkloadKindMCPRemoteProxy, Name: proxyName}
834834
for _, ref := range updated.Status.ReferencingWorkloads {
835835
if ref == expectedRef {
836836
return false

0 commit comments

Comments
 (0)