yaml tags on telemetry.Config

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>

Author: jerm-dro

pkg/telemetry/config.go

@@ -20,50 +20,50 @@ import (
 // Config holds the configuration for OpenTelemetry instrumentation.
 type Config struct {
 	// Endpoint is the OTLP endpoint URL
-	Endpoint string `json:"endpoint"`
+	Endpoint string `json:"endpoint" yaml:"endpoint"`
 
 	// ServiceName is the service name for telemetry
-	ServiceName string `json:"serviceName"`
+	ServiceName string `json:"serviceName" yaml:"serviceName"`
 
 	// ServiceVersion is the service version for telemetry
-	ServiceVersion string `json:"serviceVersion"`
+	ServiceVersion string `json:"serviceVersion" yaml:"serviceVersion"`
 
 	// TracingEnabled controls whether distributed tracing is enabled
 	// When false, no tracer provider is created even if an endpoint is configured
-	TracingEnabled bool `json:"tracingEnabled"`
+	TracingEnabled bool `json:"tracingEnabled" yaml:"tracingEnabled"`
 
 	// MetricsEnabled controls whether OTLP metrics are enabled
 	// When false, OTLP metrics are not sent even if an endpoint is configured
 	// This is independent of EnablePrometheusMetricsPath
-	MetricsEnabled bool `json:"metricsEnabled"`
+	MetricsEnabled bool `json:"metricsEnabled" yaml:"metricsEnabled"`
 
 	// SamplingRate is the trace sampling rate (0.0-1.0)
 	// Only used when TracingEnabled is true
-	SamplingRate float64 `json:"samplingRate"`
+	SamplingRate float64 `json:"samplingRate" yaml:"samplingRate"`
 
 	// Headers contains authentication headers for the OTLP endpoint
-	Headers map[string]string `json:"headers"`
+	Headers map[string]string `json:"headers" yaml:"headers"`
 
 	// Insecure indicates whether to use HTTP instead of HTTPS for the OTLP endpoint
-	Insecure bool `json:"insecure"`
+	Insecure bool `json:"insecure" yaml:"insecure"`
 
 	// EnablePrometheusMetricsPath controls whether to expose Prometheus-style /metrics endpoint
 	// The metrics are served on the main transport port at /metrics
 	// This is separate from OTLP metrics which are sent to the Endpoint
-	EnablePrometheusMetricsPath bool `json:"enablePrometheusMetricsPath"`
+	EnablePrometheusMetricsPath bool `json:"enablePrometheusMetricsPath" yaml:"enablePrometheusMetricsPath"`
 
 	// EnvironmentVariables is a list of environment variable names that should be
 	// included in telemetry spans as attributes. Only variables in this list will
 	// be read from the host machine and included in spans for observability.
 	// Example: []string{"NODE_ENV", "DEPLOYMENT_ENV", "SERVICE_VERSION"}
-	EnvironmentVariables []string `json:"environmentVariables"`
+	EnvironmentVariables []string `json:"environmentVariables" yaml:"environmentVariables"`
 
 	// CustomAttributes contains custom resource attributes to be added to all telemetry signals.
 	// These are parsed from CLI flags (--otel-custom-attributes) or environment variables
 	// (OTEL_RESOURCE_ATTRIBUTES) as key=value pairs.
 	// We use map[string]string for proper JSON serialization instead of []attribute.KeyValue
 	// which doesn't marshal/unmarshal correctly.
-	CustomAttributes map[string]string `json:"customAttributes,omitempty"`
+	CustomAttributes map[string]string `json:"customAttributes,omitempty" yaml:"customAttributes,omitempty"`
 }
 
 // DefaultConfig returns a default telemetry configuration.

pkg/vmcp/config/yaml_loader_transform_test.go

@@ -776,22 +776,21 @@ func TestYAMLLoader_transformCompositeTools_WithOutputConfig(t *testing.T) {
 func TestYAMLLoader_transformTelemetryConfig(t *testing.T) {
 	t.Parallel()
 
-	// Note: yaml.v3 uses lowercase field names by default (no yaml tags on telemetry.Config)
 	yamlContent := `
 name: telemetry-test
 telemetry:
   endpoint: "localhost:4318"
-  servicename: "test-service"
-  serviceversion: "1.2.3"
-  tracingenabled: true
-  metricsenabled: true
-  samplingrate: 0.75
+  serviceName: "test-service"
+  serviceVersion: "1.2.3"
+  tracingEnabled: true
+  metricsEnabled: true
+  samplingRate: 0.75
   insecure: true
-  enableprometheusmetricspath: true
+  enablePrometheusMetricsPath: true
   headers:
     Authorization: "Bearer token123"
     X-Custom-Header: "custom-value"
-  environmentvariables:
+  environmentVariables:
     - "NODE_ENV"
     - "DEPLOYMENT_ENV"
 `