Fix runtime_config round-trip response behavior

Author: slyt3

pkg/api/v1/workload_service.go

@@ -7,20 +7,20 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"log/slog"
 	"strings"
 	"time"
 
 	nameref "github.com/google/go-containerregistry/pkg/name"
+	regtypes "github.com/stacklok/toolhive-core/registry/types"
 	groupval "github.com/stacklok/toolhive-core/validation/group"
 	httpval "github.com/stacklok/toolhive-core/validation/http"
 	"github.com/stacklok/toolhive/pkg/auth/remote"
 	"github.com/stacklok/toolhive/pkg/config"
 	"github.com/stacklok/toolhive/pkg/container/runtime"
 	"github.com/stacklok/toolhive/pkg/container/templates"
 	"github.com/stacklok/toolhive/pkg/groups"
-	"github.com/stacklok/toolhive/pkg/logger"
 	"github.com/stacklok/toolhive/pkg/networking"
-	regtypes "github.com/stacklok/toolhive/pkg/registry/registry"
 	"github.com/stacklok/toolhive/pkg/runner"
 	"github.com/stacklok/toolhive/pkg/runner/retriever"
 	"github.com/stacklok/toolhive/pkg/secrets"
@@ -94,13 +94,13 @@ func (s *WorkloadService) CreateWorkloadFromRequest(ctx context.Context, req *cr
 
 	// Save the workload state
 	if err := runConfig.SaveState(ctx); err != nil {
-		logger.Errorf("Failed to save workload config: %v", err)
+		slog.Error("failed to save workload config", "error", err)
 		return nil, fmt.Errorf("failed to save workload config: %w", err)
 	}
 
 	// Start workload
 	if err := s.workloadManager.RunWorkloadDetached(ctx, runConfig); err != nil {
-		logger.Errorf("Failed to start workload: %v", err)
+		slog.Error("failed to start workload", "error", err)
 		return nil, fmt.Errorf("failed to start workload: %w", err)
 	}
 
@@ -112,7 +112,7 @@ func (s *WorkloadService) UpdateWorkloadFromRequest(ctx context.Context, name st
 	// If ProxyPort is 0, reuse the existing port
 	if req.ProxyPort == 0 && existingPort > 0 {
 		req.ProxyPort = existingPort
-		logger.Debugf("Reusing existing port %d for workload %s", existingPort, name)
+		slog.Debug("reusing existing port", "port", existingPort, "name", name)
 	}
 
 	// Build the full run config
@@ -345,7 +345,7 @@ func (s *WorkloadService) BuildFullRunConfig(
 
 	runConfig, err := runner.NewRunConfigBuilder(ctx, imageMetadata, req.EnvVars, &runner.DetachedEnvVarValidator{}, options...)
 	if err != nil {
-		logger.Errorf("Failed to build run config: %v", err)
+		slog.Error("failed to build run config", "error", err)
 		return nil, fmt.Errorf("%w: Failed to build run config: %w", retriever.ErrInvalidRunConfig, err)
 	}
 

pkg/api/v1/workloads_types_test.go

@@ -13,7 +13,7 @@ import (
 	"github.com/stacklok/toolhive/pkg/auth"
 	"github.com/stacklok/toolhive/pkg/auth/remote"
 	"github.com/stacklok/toolhive/pkg/container/templates"
-	"github.com/stacklok/toolhive/pkg/permissions"
+	"github.com/stacklok/toolhive-core/permissions"
 	"github.com/stacklok/toolhive/pkg/runner"
 	"github.com/stacklok/toolhive/pkg/secrets"
 	"github.com/stacklok/toolhive/pkg/transport/types"