Fix stale MCPOIDCConfig printer column JSONPaths#4530
Merged
Conversation
The printer columns for Ready and References on MCPOIDCConfig still pointed at the old condition type (Valid) and status field (referencingServers) after they were renamed in PRs #4490 and #4492. This caused both columns to show empty in kubectl output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisJBurns
requested review from
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4530 +/- ##
==========================================
- Coverage 69.08% 69.03% -0.05%
==========================================
Files 505 505
Lines 52144 52144
==========================================
- Hits 36023 36000 -23
- Misses 13336 13357 +21
- Partials 2785 2787 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jerm-dro
approved these changes
Apr 3, 2026
MatteoManzoni
pushed a commit
to DocPlanner/toolhive
that referenced
this pull request
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCPOIDCConfig printer columns for
ReadyandReferenceswere not updated when the condition type was renamed fromValidtoReady(PR #4490) and the status field was renamed fromreferencingServerstoreferencingWorkloads(PR #4492). This caused both columns to show empty inkubectl get mcpoidcoutput.Readycolumn JSONPath from@.type=='Valid'to@.type=='Ready'Referencescolumn JSONPath from.status.referencingServersto.status.referencingWorkloadstask operator-manifestsType of change
Test plan
task test) — MCPOIDCConfig controller tests passtask lint-fix) — no new issues (pre-existing unparam in unrelated file)Does this introduce a user-facing change?
Yes.
kubectl get mcpoidcwill now correctly display theREADYandREFERENCEScolumns instead of showing empty values.Generated with Claude Code