[fix] Restricts update date validation for non-maintenance events#204
Merged
Conversation
Updates the update date validation logic to only enforce that the update date cannot be earlier than the start date for non-maintenance event types. This change allows maintenance events to bypass this restriction, accommodating different scheduling needs.
Aloento
requested review from
SebastianGode,
anton-sidelnikov,
bakhterets and
sgmv
Contributor
|
You should exhibit this behaviour not only for maintenance, but also for the info event. |
sgmv
requested changes
Jul 21, 2025
Contributor
sgmv
left a comment
sgmv
left a comment
There was a problem hiding this comment.
Please add the same for the info event type.
Updates the date validation logic to ensure that the update date cannot be earlier than the start date for non-incident event types. This change improves the accuracy of the event management process by preventing invalid date entries.
Adjusts the condition for validating the update date to ensure it only restricts incidents when the update date is earlier than the start date. This change enhances the user experience by preventing incorrect date entries for incident events.
sgmv
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the update date validation logic to only enforce that the update date cannot be earlier than the start date for non-maintenance event types.
This change allows maintenance events to bypass this restriction, accommodating different scheduling needs.