[fix] Update end date field requirement based on event type#209
Merged
Conversation
Changes the requirement for the end date field in the event editor and new form to only be mandatory when the event type is Maintenance. This improves user experience by ensuring that the field is conditionally required, preventing unnecessary errors for other event types.
Aloento
requested review from
SebastianGode,
anton-sidelnikov,
bakhterets and
sgmv
Contributor
|
Is blocked by stackmon/status-dashboard-v3#101 |
sgmv
requested changes
Jul 22, 2025
Contributor
sgmv
left a comment
sgmv
left a comment
There was a problem hiding this comment.
Unfortunately, it has a bug. The info event has 2 updates, but it shows only one with a wrong status.
Member
Author
|
PATCH /v2/incidents/608 
...can you help? Is 'active' not a valid status? @sgmv |
# Conflicts: # src/Components/Event/EventEditor.tsx
Implements support for the Active status case in the TransformerV2 function. This enhancement allows the system to correctly return the EventStatus.Active when dealing with active statuses, improving overall event handling.
Contributor
You still have a wrong status for the info event.
|
Member
Author
Member
Author
I didn't find any problems. If you look closely at the screenshot you provided, the planned status occurred after the active status (47 > 24), so it is correct that it is displayed as planned. |
Contributor
|
The bug relates to this issue #213 |
sgmv
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the requirement for the end date field in the event editor and new form to only be mandatory when the event type is Maintenance.
This improves user experience by ensuring that the field is conditionally required, preventing unnecessary errors for other event types.