regression: server not rejecting user's attempts to call themselves (RocketChat#40229)

Author: pierre-lehnen-rc

apps/meteor/server/services/media-call/service.ts

@@ -335,7 +335,9 @@ export class MediaCallService extends ServiceClassInternal implements IMediaCall
 	}
 
 	private async getRoomIdForInternalCall(call: IMediaCall): Promise<IRoom> {
-		const room = await Rooms.findOneDirectRoomContainingAllUserIDs(call.uids);
+		const uniqueUids = [...new Set(call.uids)];
+
+		const room = await Rooms.findOneDirectRoomContainingAllUserIDs(uniqueUids);
 		if (room) {
 			return room;
 		}

ee/packages/media-calls/src/internal/InternalCallProvider.ts

@@ -13,6 +13,10 @@ export class InternalCallProvider extends BaseCallProvider {
 			throw new CallRejectedError('unsupported');
 		}
 
+		if (params.caller.id === params.callee.id) {
+			throw new CallRejectedError('unsupported');
+		}
+
 		if (await MediaCalls.hasUnfinishedCallsByUid(params.caller.id, params.parentCallId)) {
 			throw new CallRejectedError('busy');
 		}