Avoid unnecesary use of legacy eslint config style

Makes eslint v10 upgrade easier.

Author: chadlwilson

.github/dependabot.yml

@@ -25,8 +25,10 @@ updates:
       jasmine:
         patterns: ["jasmine*", "@types/jasmine*"]
       webpack:
-        patterns: ["webpack*", "@types/webpack*", "*-loader", "*-webpack-plugin", "*mini-css-extract-plugin", "@babel/*"]
+        patterns: ["webpack*", "*-loader", "*-webpack-plugin", "*mini-css-extract-plugin", "@babel/*"]
         exclude-patterns: ["karma-*-loader"]
+      eslint:
+        patterns: [ "eslint*", "@eslint/*", "@types/eslint*" ]
       types:
         patterns: ["@types/*"]
   - package-ecosystem: bundler

server/src/main/webapp/WEB-INF/rails/app/assets/javascripts/vsm_renderer.js

@@ -276,7 +276,8 @@ Graph_Renderer = function (container) {
   }
 
   function renderScmEntity(node) {
-    var gui = '', node_name = '';
+    var gui = '';
+    var node_name;
     var modification = firstModification(node);
 
     if (modification) {
@@ -502,9 +503,7 @@ Graph_Renderer = function (container) {
   }
 
   function renderPipelineInstance(node_id, instance, node) {
-    var gui = '';
-    var stagesCount = 0;
-    gui += '<li class="instance">';
+    var gui = '<li class="instance">';
     if (instance.label != '') {
       if (isCurrent) {
         gui += `<h4 title="${_.escape(instance.label)}"><span class="pipeline_run_label">Instance: ${_.escape(instance.label)}</span></h4>`;
@@ -517,7 +516,7 @@ Graph_Renderer = function (container) {
       gui += `<span class="duration">Duration: ${duration}</span>`;
 
       gui += '<ul class="stages">';
-      stagesCount = instance.stages.length;
+      var stagesCount = instance.stages.length;
       for (var i = 0; i < stagesCount; i++) {
         var stagesWidth = (node_id == current) ? 238 : 196;
         gui += '<li class="stage_bar ';

server/src/main/webapp/WEB-INF/rails/eslint-old.config.mjs

@@ -16,17 +16,12 @@
 
 import globals from "globals";
 import js from "@eslint/js";
-import {FlatCompat} from "@eslint/eslintrc";
-
-const compat = new FlatCompat({
-  recommendedConfig: js.configs.recommended,
-});
 
 export const nonWebPackedLegacyConfig = {
   files: ["app/assets/javascripts/**/*.js", "spec/javascripts/**/*.js"],
   ignores: ["spec/javascripts/support/**"],
 
-  extends: compat.extends("eslint:recommended"),
+  extends: [js.configs.recommended],
 
   languageOptions: {
     globals: {

server/src/main/webapp/WEB-INF/rails/eslint.config.mjs

@@ -17,14 +17,9 @@
 import {defineConfig, globalIgnores} from "eslint/config";
 import globals from "globals";
 import js from "@eslint/js";
-import {FlatCompat} from "@eslint/eslintrc";
 import {nonWebPackedLegacyConfig} from "./eslint-old.config.mjs";
 import {webpackedConfig} from "./eslint-webpacked.config.mjs";
 
-const compat = new FlatCompat({
-  recommendedConfig: js.configs.recommended,
-});
-
 const globalIgnoreConfig = globalIgnores([
   "gems",                       // Gems
   "tmp",                        // Temporary typescript output dir
@@ -44,7 +39,7 @@ const buildScriptingConfig = {
     "webpack/**/*", // Webpacked JS linted separately
     "spec/**/*",    // Webpacked JS linted separately
   ],
-  extends: compat.extends("eslint:recommended"),
+  extends: [js.configs.recommended],
   languageOptions: {
     globals: {
       ...globals.node,

server/src/main/webapp/WEB-INF/rails/package.json

@@ -53,6 +53,7 @@
     "@babel/eslint-parser": "^7.28.6",
     "@babel/preset-env": "^7.29.0",
     "@babel/preset-react": "^7.28.5",
+    "@eslint/js": "^9.39.2",
     "@types/awesomplete": "^1.1.16",
     "@types/fs-extra": "^11.0.4",
     "@types/jasmine": "^5.1.15",
@@ -76,6 +77,7 @@
     "file-loader": "^6.2.0",
     "fork-ts-checker-webpack-plugin": "^9.1.0",
     "fs-extra": "^11.3.3",
+    "globals": "^17.3.0",
     "html-webpack-plugin": "^5.6.6",
     "jasmine": "^5.13.0",
     "jasmine-ajax": "^4.0.0",

server/src/main/webapp/WEB-INF/rails/yarn.lock

@@ -1384,7 +1384,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@eslint/js@npm:9.39.2":
+"@eslint/js@npm:9.39.2, @eslint/js@npm:^9.39.2":
   version: 9.39.2
   resolution: "@eslint/js@npm:9.39.2"
   checksum: 10/6b7f676746f3111b5d1b23715319212ab9297868a0fa9980d483c3da8965d5841673aada2d5653e85a3f7156edee0893a7ae7035211b4efdcb2848154bb947f2
@@ -4808,6 +4808,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"globals@npm:^17.3.0":
+  version: 17.3.0
+  resolution: "globals@npm:17.3.0"
+  checksum: 10/44ba2b7db93eb6a2531dfba09219845e21f2e724a4f400eb59518b180b7d5bcf7f65580530e3d3023d7dc2bdbacf5d265fd87c393f567deb9a2b0472b51c9d5e
+  languageName: node
+  linkType: hard
+
 "globalthis@npm:^1.0.4":
   version: 1.0.4
   resolution: "globalthis@npm:1.0.4"
@@ -4861,6 +4868,7 @@ __metadata:
     "@babel/eslint-parser": "npm:^7.28.6"
     "@babel/preset-env": "npm:^7.29.0"
     "@babel/preset-react": "npm:^7.28.5"
+    "@eslint/js": "npm:^9.39.2"
     "@fortawesome/fontawesome-free": "npm:^6.7.2"
     "@shopify/draggable": "npm:1.2.1"
     "@types/awesomplete": "npm:^1.1.16"
@@ -4895,6 +4903,7 @@ __metadata:
     fork-ts-checker-webpack-plugin: "npm:^9.1.0"
     foundation-sites: "npm:^6.9.0"
     fs-extra: "npm:^11.3.3"
+    globals: "npm:^17.3.0"
     hack-font: "npm:^3.3.0"
     html-webpack-plugin: "npm:^5.6.6"
     jasmine: "npm:^5.13.0"