ROX-28461: Add change cloud_account and subscription_Id admin endpoint (#2330)

* Add change cloud account admin endpoint

* Revert rds moq changes

* Add subscription_id change

* Rollback rds moq change

* Add subscription change

Author: kurlov

.secrets.baseline

@@ -268,7 +268,7 @@
         "filename": "internal/central/pkg/services/centralservice_moq.go",
         "hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
         "is_verified": false,
-        "line_number": 1112
+        "line_number": 1180
       }
     ],
     "pkg/client/fleetmanager/impl/testdata/token": [
@@ -391,5 +391,5 @@
       }
     ]
   },
-  "generated_at": "2025-05-12T10:17:39Z"
+  "generated_at": "2025-06-10T08:35:01Z"
 }

internal/central/pkg/api/admin/private/api/openapi.yaml

@@ -68,6 +68,9 @@ type AdminCentralHandler interface {
 
 	// PatchBillingParameters changes the billing model of a central
 	PatchBillingParameters(w http.ResponseWriter, r *http.Request)
+
+	// PatchSubscriptionParameters changes the subscription and cloud account of a central
+	PatchSubscriptionParameters(w http.ResponseWriter, r *http.Request)
 }
 
 type adminCentralHandler struct {
@@ -424,3 +427,15 @@ func (h adminCentralHandler) PatchBillingParameters(w http.ResponseWriter, r *ht
 	}
 	handlers.Handle(w, r, cfg, http.StatusOK)
 }
+
+func (h adminCentralHandler) PatchSubscriptionParameters(w http.ResponseWriter, r *http.Request) {
+	var request *private.CentralSubscriptionChangeRequest
+	cfg := &handlers.HandlerConfig{
+		MarshalInto: &request,
+		Action: func() (i any, serviceError *errors.ServiceError) {
+			return nil, h.service.ChangeSubscription(r.Context(), mux.Vars(r)["id"],
+				request.CloudAccountId, request.CloudProvider, request.SubscriptionId)
+		},
+	}
+	handlers.Handle(w, r, cfg, http.StatusOK)
+}

internal/central/pkg/api/admin/private/api_default.go

@@ -233,6 +233,9 @@ func (s *options) buildAPIBaseRouter(mainRouter *mux.Router, basePath string) er
 	adminCentralsRouter.HandleFunc("/{id}/billing", adminCentralHandler.PatchBillingParameters).
 		Name(logger.NewLogEvent("admin-billing", "[admin] change central billing parameters").ToString()).
 		Methods(http.MethodPatch)
+	adminCentralsRouter.HandleFunc("/{id}/subscription", adminCentralHandler.PatchSubscriptionParameters).
+		Name(logger.NewLogEvent("admin-subscription", "[admin] change central subscription parameters").ToString()).
+		Methods(http.MethodPatch)
 
 	if features.ClusterMigration.Enabled() {
 		adminCentralsRouter.HandleFunc("/{id}/assign-cluster", adminCentralHandler.AssignCluster).

internal/central/pkg/api/admin/private/model_central_subscription_change_request.go

@@ -118,6 +118,7 @@ type CentralService interface {
 	ResetCentralSecretBackup(ctx context.Context, centralRequest *dbapi.CentralRequest) *errors.ServiceError
 	ChangeBillingParameters(ctx context.Context, centralID string, billingModel string, cloudAccountID string, cloudProvider string, product string) *errors.ServiceError
 	AssignCluster(ctx context.Context, centralID string, clusterID string) *errors.ServiceError
+	ChangeSubscription(ctx context.Context, centralID string, cloudAccountID string, cloudProvider string, subscriptionID string) *errors.ServiceError
 }
 
 var _ CentralService = &centralService{}
@@ -1143,3 +1144,23 @@ func (k *centralService) ChangeBillingParameters(ctx context.Context, centralID
 	}
 	return nil
 }
+
+// ChangeSubscription implements CentralService.
+func (k *centralService) ChangeSubscription(ctx context.Context, centralID string, cloudAccountID string, cloudProvider string, subscriptionID string) *errors.ServiceError {
+	centralRequest, svcErr := k.GetByID(centralID)
+	if svcErr != nil {
+		return svcErr
+	}
+
+	centralRequest.CloudProvider = cloudProvider
+	centralRequest.CloudAccountID = cloudAccountID
+	centralRequest.SubscriptionID = subscriptionID
+
+	if svcErr = k.UpdateIgnoreNils(centralRequest); svcErr != nil {
+		glog.Errorf("Failed to update central %q record with subscription_id %q and updated cloud account %q: %v", centralID, subscriptionID, cloudAccountID, svcErr)
+		return svcErr
+	}
+
+	glog.Infof("Central %q cloud account parameters have been changed to %q with id %q", centralID, cloudProvider, cloudAccountID)
+	return nil
+}

internal/central/pkg/handlers/admin_central.go

@@ -302,3 +302,33 @@ func Test_centralService_ChangeBillingParameters(t *testing.T) {
 	deleteQuotaCalls := quotaService.DeleteQuotaCalls()
 	require.Len(t, deleteQuotaCalls, 0)
 }
+
+func Test_centralService_ChangeSubscription(t *testing.T) {
+	service := &centralService{
+		connectionFactory: db.NewMockConnectionFactory(nil),
+	}
+	central := buildCentralRequest(func(centralRequest *dbapi.CentralRequest) {
+		centralRequest.CloudProvider = ""
+		centralRequest.CloudAccountID = ""
+		centralRequest.SubscriptionID = "original_subscription_id"
+	})
+
+	catcher := mocket.Catcher.Reset()
+	q0 := catcher.NewMock().WithQuery(`SELECT * FROM "central_requests" `+
+		`WHERE id = $1 AND "central_requests"."deleted_at" IS NULL `+
+		`ORDER BY "central_requests"."id" LIMIT $2`).
+		OneTime().WithArgs(testID, int64(1)).
+		WithReply(converters.ConvertCentralRequest(central))
+	q1 := catcher.NewMock().WithQuery(`UPDATE "central_requests" ` +
+		`SET "updated_at"=$1,"deleted_at"=$2,"region"=$3,"cluster_id"=$4,` +
+		`"cloud_provider"=$5,"cloud_account_id"=$6,"name"=$7,"subscription_id"=$8,"owner"=$9 ` +
+		`WHERE status not IN ($10,$11) AND "central_requests"."deleted_at" IS NULL AND "id" = $12`).
+		OneTime()
+
+	svcErr := service.ChangeSubscription(context.Background(), central.ID, "aws_account_id", "aws", "new_subscription_id")
+	assert.Nil(t, svcErr)
+
+	assert.True(t, q0.Triggered)
+	assert.True(t, q1.Triggered)
+
+}