external-dns reconciliation logic (#2377)

Author: ludydoo

internal/central/pkg/externaldns/externaldns.go

@@ -0,0 +1,9 @@
+package externaldns
+
+import "github.com/stackrox/acs-fleet-manager/internal/central/pkg/api/private"
+
+// IsEnabled checks if the external DNS feature is enabled for the given managed central.
+func IsEnabled(managedCentral private.ManagedCentral) bool {
+	isEnabled, ok := managedCentral.Spec.TenantResourcesValues["externalDnsEnabled"].(bool)
+	return ok && isEnabled
+}

internal/central/pkg/services/central.go

@@ -15,6 +15,8 @@ import (
 	"github.com/stackrox/acs-fleet-manager/internal/central/pkg/api/dbapi"
 	"github.com/stackrox/acs-fleet-manager/internal/central/pkg/centrals/types"
 	"github.com/stackrox/acs-fleet-manager/internal/central/pkg/config"
+	"github.com/stackrox/acs-fleet-manager/internal/central/pkg/externaldns"
+	"github.com/stackrox/acs-fleet-manager/internal/central/pkg/presenters"
 	"github.com/stackrox/acs-fleet-manager/internal/central/pkg/rhsso"
 	"github.com/stackrox/acs-fleet-manager/pkg/api"
 	"github.com/stackrox/acs-fleet-manager/pkg/auth"
@@ -137,13 +139,14 @@ type centralService struct {
 	iamConfig                *iam.IAMConfig
 	rhSSODynamicClientsAPI   *dynamicClientAPI.AcsTenantsApiService
 	telemetry                *Telemetry
+	managedCentralPresenter  *presenters.ManagedCentralPresenter
 }
 
 // NewCentralService ...
 func NewCentralService(connectionFactory *db.ConnectionFactory, clusterService ClusterService,
 	iamConfig *iam.IAMConfig, centralConfig *config.CentralConfig, dataplaneClusterConfig *config.DataplaneClusterConfig, awsConfig *config.AWSConfig,
 	quotaServiceFactory QuotaServiceFactory, awsClientFactory aws.ClientFactory,
-	clusterPlacementStrategy ClusterPlacementStrategy, amsClient ocm.AMSClient, telemetry *Telemetry) CentralService {
+	clusterPlacementStrategy ClusterPlacementStrategy, amsClient ocm.AMSClient, telemetry *Telemetry, managedCentralPresenter *presenters.ManagedCentralPresenter) CentralService {
 	return &centralService{
 		connectionFactory:        connectionFactory,
 		clusterService:           clusterService,
@@ -157,6 +160,7 @@ func NewCentralService(connectionFactory *db.ConnectionFactory, clusterService C
 		amsClient:                amsClient,
 		rhSSODynamicClientsAPI:   dynamicclients.NewDynamicClientsAPI(iamConfig.RedhatSSORealm),
 		telemetry:                telemetry,
+		managedCentralPresenter:  managedCentralPresenter,
 	}
 }
 
@@ -597,8 +601,12 @@ func (k *centralService) Delete(centralRequest *dbapi.CentralRequest, force bool
 		if err != nil {
 			return errors.NewWithCause(errors.ErrorGeneral, err, "failed to get routes")
 		}
+		managedCentral, err := k.managedCentralPresenter.PresentManagedCentral(centralRequest)
+		if err != nil {
+			return errors.NewWithCause(errors.ErrorGeneral, err, "failed to present managed central")
+		}
 		// Only delete the routes when they are set
-		if routes != nil && k.centralConfig.EnableCentralExternalDomain {
+		if routes != nil && k.centralConfig.EnableCentralExternalDomain && !externaldns.IsEnabled(managedCentral) {
 			_, err := k.ChangeCentralCNAMErecords(centralRequest, CentralRoutesActionDelete)
 			if err != nil {
 				if force {

internal/central/pkg/workers/centralmgrs/centrals_routes_cname_mgr.go

@@ -5,6 +5,8 @@ import (
 	"github.com/google/uuid"
 	"github.com/pkg/errors"
 	"github.com/stackrox/acs-fleet-manager/internal/central/pkg/config"
+	"github.com/stackrox/acs-fleet-manager/internal/central/pkg/externaldns"
+	"github.com/stackrox/acs-fleet-manager/internal/central/pkg/presenters"
 	"github.com/stackrox/acs-fleet-manager/internal/central/pkg/services"
 	"github.com/stackrox/acs-fleet-manager/pkg/metrics"
 	"github.com/stackrox/acs-fleet-manager/pkg/workers"
@@ -15,23 +17,25 @@ const centralDNSWorkerType = "central_dns"
 // CentralRoutesCNAMEManager ...
 type CentralRoutesCNAMEManager struct {
 	workers.BaseWorker
-	centralService services.CentralService
-	centralConfig  *config.CentralConfig
+	centralService          services.CentralService
+	centralConfig           *config.CentralConfig
+	managedCentralPresenter *presenters.ManagedCentralPresenter
 }
 
 var _ workers.Worker = &CentralRoutesCNAMEManager{}
 
 // NewCentralCNAMEManager ...
-func NewCentralCNAMEManager(centralService services.CentralService, centralConfig *config.CentralConfig) *CentralRoutesCNAMEManager {
+func NewCentralCNAMEManager(centralService services.CentralService, centralConfig *config.CentralConfig, managedCentralPresenter *presenters.ManagedCentralPresenter) *CentralRoutesCNAMEManager {
 	metrics.InitReconcilerMetricsForType(centralDNSWorkerType)
 	return &CentralRoutesCNAMEManager{
 		BaseWorker: workers.BaseWorker{
 			ID:         uuid.New().String(),
 			WorkerType: centralDNSWorkerType,
 			Reconciler: workers.Reconciler{},
 		},
-		centralService: centralService,
-		centralConfig:  centralConfig,
+		centralService:          centralService,
+		centralConfig:           centralConfig,
+		managedCentralPresenter: managedCentralPresenter,
 	}
 }
 
@@ -58,7 +62,12 @@ func (k *CentralRoutesCNAMEManager) Reconcile() []error {
 	}
 
 	for _, central := range centrals {
-		if k.centralConfig.EnableCentralExternalDomain {
+		managedCentral, err := k.managedCentralPresenter.PresentManagedCentral(central)
+		if err != nil {
+			errs = append(errs, errors.Wrapf(err, "failed to present managed central for central %s", central.ID))
+			continue
+		}
+		if k.centralConfig.EnableCentralExternalDomain && !externaldns.IsEnabled(managedCentral) {
 			if central.RoutesCreationID == "" {
 				glog.Infof("creating CNAME records for central %s", central.ID)