Skip to content

Commit faf1bb5

Browse files
committed
Cleaned up some comments
1 parent f2aa0fc commit faf1bb5

1 file changed

Lines changed: 2 additions & 11 deletions

File tree

tests/test_path_rmdir.py

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@ def test_rmdir_empty(monitored_dir, server, fact_config, dirname):
5353
5454
Scenario: File is removed first, leaving an empty directory, then rmdir is called.
5555
56-
For now, directory deletion events are reported (like file unlink).
57-
Later, these events will be filtered out but inode cleanup will still happen.
58-
5956
We use exact delta matching because:
6057
- Each test has an isolated monitored_dir
6158
- Periodic scans are disabled (scan_interval: 0)
@@ -104,10 +101,9 @@ def test_rmdir_empty(monitored_dir, server, fact_config, dirname):
104101
f"Expected exactly 1 inode removed for file deletion, got {file_delta}"
105102

106103
# Now remove the empty directory with rmdir
107-
# Note: Directory deletions are tracked internally but not sent as events to sensors
108104
os.rmdir(test_dir)
109105

110-
# Check that directory deletion incremented both metrics by exactly 1
106+
# Check metrics after directory deletion
111107
final_inode_removed = get_inode_removed_count(fact_config)
112108
final_kernel_rmdir = get_kernel_rmdir_processed(fact_config)
113109

@@ -186,9 +182,7 @@ def test_rmdir_recursive_with_rm(monitored_dir, server, fact_config):
186182
if proc.returncode != 0:
187183
raise RuntimeError(f"rm command failed with exit code {proc.returncode}")
188184

189-
# Only file deletions are reported as events
190-
# Directory deletions are tracked internally but not sent to sensors
191-
# rm -rf deletes depth-first: file3, file2, file1
185+
# Wait for file deletion events (rm -rf deletes depth-first)
192186
unlink_events = [
193187
Event(process=rm_process, event_type=EventType.UNLINK,
194188
file=file3, host_path=file3),
@@ -267,8 +261,6 @@ def test_rmdir_ignored(monitored_dir, ignored_dir, server, fact_config):
267261
os.remove(monitored_file)
268262
os.rmdir(monitored_subdir)
269263

270-
# Only file deletion is reported as an event
271-
# Directory deletions are tracked internally but not sent to sensors
272264
deletion_events = [
273265
Event(process=process, event_type=EventType.UNLINK,
274266
file=monitored_file, host_path=monitored_file),
@@ -335,7 +327,6 @@ def test_rmdir_with_parent_inode(monitored_dir, server, fact_config):
335327
os.rmdir(subdir)
336328

337329
# Verify file deletion is tracked
338-
# Directory deletions are tracked internally but not sent to sensors
339330
deletion_events = [
340331
Event(process=process, event_type=EventType.UNLINK,
341332
file=test_file, host_path=test_file),

0 commit comments

Comments
 (0)