Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@fact/src/config/mod.rs`:
- Line 44: The new replay field in the configuration schema is missing dedicated
test coverage. Update fact/src/config/tests.rs to add cases that parse a YAML
replay: <path> value, exercise the replay() accessor, and verify update() merges
a Some(path) value correctly; use the existing Config and update() test patterns
as the reference point. Also extend the fully specified config fixtures that
already include replay: None so they cover the new field consistently, but make
sure there is at least one explicit test for parsing and merging replay.

In `@fact/src/event/process.rs`:
- Around line 41-48: The Process.username field is only marked
skip_deserializing, so replayed events keep the default empty value and never
get repopulated. Update the Process struct’s serde handling to mirror the
Event.hostname fix by adding a default provider (or equivalent reassignment
path) for username in fact/src/event/process.rs, and ensure the
replay/deserialization flow restores a usable username instead of leaving it
blank.

In `@fact/src/replay.rs`:
- Around line 13-61: The replay task in start() is being treated as a global
shutdown signal when it reaches EOF, which can stop downstream consumers before
their bounded queues are drained. Update the replay completion path so finishing
the file does not flip the shared running flag in run(); instead, keep replay
completion separate from shutdown or add an explicit drain/flush step for
RateLimiter and Output before exit. Use the start() task and the
run()/running.changed() shutdown flow to locate the fix.

---

Outside diff comments:
In `@fact/src/event/mod.rs`:
- Around line 73-80: The Event deserialization currently drops hostname to an
empty value, which then gets forwarded unchanged by the replay path. Update the
Event type’s serde handling so hostname is preserved or restored during
deserialization, and verify the replay logic in replay.rs / FileActivity
construction uses the recorded hostname instead of the blank default.

---

Nitpick comments:
In `@fact-ebpf/src/lib.rs`:
- Around line 108-194: Add small unit tests for the new manual serde
implementations in inode_key_t and monitored_t to cover serialize-to-deserialize
round trips. Use the existing Serialize/Deserialize impls for inode_key_t and
monitored_t to verify that a value serialized to JSON (or equivalent serde
format) deserializes back to the same value, including at least one case for
each monitored_t variant and a representative inode_key_t value. Place the tests
near the serde impls in lib.rs so they clearly exercise these symbols and
prevent drift between the custom serialization and deserialization logic.

In `@fact/src/replay.rs`:
- Around line 13-61: Add coverage for replay::start by introducing a test that
spawns it with a temporary JSONL file and a watch receiver, then verifies the
reader forwards valid Event entries, skips malformed JSON lines, and continues
after deserialize failures. Use the start function and its line-by-line parsing
path in replay.rs so the test exercises the existing parse/skip/forward behavior
end to end.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@fact/src/lib.rs`:
- Around line 89-148: Update run() to drain the outer task_set after
running.send(false) on normal shutdown, including Ctrl-C and SIGTERM when
is_replay is false, awaiting each task and propagating errors through
flatten_task_result. Preserve the existing replay draining behavior while
ensuring task_set is not dropped until all pipeline tasks have finished
flushing.

---

Nitpick comments:
In `@fact-ebpf/src/lib.rs`:
- Around line 108-150: Add focused serde deserialization tests around
inode_key_t’s Deserialize implementation and the Event replay deserialization
path: verify stdout-to-replay round trips, missing inode and dev errors, ignored
unknown map keys, every monitored_t variant, and rejection of unknown variants.
Use serde_json::from_value::<Event> for replay-mode coverage and keep the tests
scoped to these behaviors.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@fact/src/lib.rs`:
- Around line 82-89: Update join_all_tasks to drain the JoinSet with repeated
join_next() calls, converting any JoinError into an anyhow::Error and
propagating task-level errors. Preserve successful completion as Ok(()) so the
shutdown call site can return failures instead of panicking.

---

Nitpick comments:
In `@fact-ebpf/src/lib.rs`:
- Around line 108-151: Add JSON round-trip regression tests covering inode_key_t
and every monitored_t variant, using serde_json::to_string followed by from_str
and asserting equality. Include invalid JSON and missing-field/value cases for
the custom deserializers, covering the deserialize implementations for
inode_key_t and monitored_t without changing their behavior.