feat(operator): implement basic fact operator#857
Draft
Molter73 wants to merge 5 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
At this point the operator is a PoC, meant only as a small experiment to see if it is even possible to implement. TODO: * Expose more configuration options. * Implement some sort of test that will ensure the operator works and deploys fact correctly.
This requires some refactoring to re-use the FactConfig struct as part of the CRD spec for fact. We also make all configuration apply through a config map, which means we can hotreload the configuration as required. Still needs more testing, but so far it looks good.
Molter73
force-pushed
the
mauro/feat/fact-operator
branch
from
cfbdf99 to
cf00347
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
==========================================
+ Coverage 27.96% 36.41% +8.44%
==========================================
Files 21 25 +4
Lines 2596 3021 +425
Branches 2596 3021 +425
==========================================
+ Hits 726 1100 +374
- Misses 1867 1916 +49
- Partials 3 5 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Molter73
force-pushed
the
mauro/feat/fact-operator
branch
from
6429ba3 to
cf00347
Compare
The tests are a bit basic, they simply generate a Fact object from a fixed spec, build the objects and compare them agains expected values. In order to simplify the daemonset tests, a DaemonSetBuilder object is created. This object can be built with default values or from a Fact object. Ultimately, the tests use both approaches to compare the final result is the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Still a WIP and more of an experiment than production ready operator.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.