Skip to content

fix: release workflow needs to start on main#858

Merged
Molter73 merged 1 commit into
mainfrom
mauro/fix/release-workflow
Jun 23, 2026
Merged

fix: release workflow needs to start on main#858
Molter73 merged 1 commit into
mainfrom
mauro/fix/release-workflow

Conversation

@Molter73

@Molter73 Molter73 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Description

The release workflow is currently broken because it checks out the release-* branch and attempts to run an action from there, this action does not exist in the release-* branch and should instead be using the version from main.

Checklist

  • Patch has a change log entry OR does not need one.
  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Summary by CodeRabbit

  • Chores
    • Updated the release workflow to improve the patch version determination process during releases.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: 843401ef-91dd-46b7-aa28-36b82618b123

📥 Commits

Reviewing files that changed from the base of the PR and between 0e7b1cb and e8142c5.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

In the release workflow, the ref: release-${{ inputs.version }} parameter is removed from the actions/checkout step. The "Determine patch version" shell script now performs an explicit git checkout release-"${VERSION}" before running git describe to compute the next patch number.

Changes

Release Workflow Checkout Refactor

Layer / File(s) Summary
Shift branch checkout from actions/checkout to shell script
.github/workflows/release.yml
Removes ref: release-${{ inputs.version }} from the actions/checkout step and adds git checkout release-"${VERSION}" at the start of the patch-version determination script.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 A ref once lived in checkout's arms so tight,
Now hops into the shell script's cozy night.
git checkout leaps with VERSION in its paw,
The same branch found, with barely any flaw.
Small moves, big hops — the rabbit knows the way! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the core fix: the release workflow needs to operate from the main branch rather than checking out the release branch before executing actions.
Description check ✅ Passed The description covers the problem, solution, and testing performed. The checklist is mostly complete with the relevant items checked, and testing confirmation is provided with a reference to the successful dry-run execution.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mauro/fix/release-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

The release workflow is currently broken because it checks out the
release-* branch and attempts to run an action from there, this action
does not exist in the release-* branch and should instead be using the
version from main.
@Molter73 Molter73 force-pushed the mauro/fix/release-workflow branch from 340798d to e8142c5 Compare June 22, 2026 14:09
@Molter73 Molter73 marked this pull request as ready for review June 22, 2026 14:11
@Molter73 Molter73 requested a review from a team as a code owner June 22, 2026 14:11
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.96%. Comparing base (0e7b1cb) to head (e8142c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   27.96%   27.96%           
=======================================
  Files          21       21           
  Lines        2596     2596           
  Branches     2596     2596           
=======================================
  Hits          726      726           
  Misses       1867     1867           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Molter73 Molter73 enabled auto-merge (squash) June 23, 2026 15:34

@JoukoVirtanen JoukoVirtanen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Molter73 Molter73 merged commit 41011dc into main Jun 23, 2026
31 checks passed
@Molter73 Molter73 deleted the mauro/fix/release-workflow branch June 23, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants