Skip to content

ROX-30296: track POSIX ACL changes via inode_set_acl LSM hook#878

Draft
Stringy wants to merge 1 commit into
mainfrom
giles/ROX-30296-track-acl
Draft

ROX-30296: track POSIX ACL changes via inode_set_acl LSM hook#878
Stringy wants to merge 1 commit into
mainfrom
giles/ROX-30296-track-acl

Conversation

@Stringy

@Stringy Stringy commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Patch has a change log entry OR does not need one.
  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: 12579f0f-e86e-4d22-abb9-962bd1d15161

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch giles/ROX-30296-track-acl

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.02%. Comparing base (d4bf87c) to head (e760024).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
fact/src/event/mod.rs 0.00% 78 Missing ⚠️
fact/src/bpf/mod.rs 0.00% 14 Missing ⚠️
fact/src/metrics/kernel_metrics.rs 0.00% 5 Missing ⚠️
fact-ebpf/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
- Coverage   27.96%   27.02%   -0.94%     
==========================================
  Files          21       21              
  Lines        2596     2686      +90     
  Branches     2596     2686      +90     
==========================================
  Hits          726      726              
- Misses       1867     1957      +90     
  Partials        3        3              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Stringy Stringy force-pushed the giles/ROX-30296-track-acl branch from 95005a8 to e760024 Compare June 23, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants