Avoid env-var-secret false positives for SECRETS_* names#1206
Avoid env-var-secret false positives for SECRETS_* names#1206arpitjain099 wants to merge 1 commit into
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1206 +/- ##
===========================================
- Coverage 62.36% 30.71% -31.65%
===========================================
Files 197 239 +42
Lines 4854 6534 +1680
===========================================
- Hits 3027 2007 -1020
- Misses 1439 4351 +2912
+ Partials 388 176 -212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes #1198.
The built-in
env-var-secretcheck used(?i).*secret.*, which also matched names likeSECRETS_DIR.This narrows the built-in pattern so plural
secretssuffixes are not flagged, and extends the fixture with aSECRETS_DIRcase to keep that behavior covered.Verification: