Skip to content

Avoid env-var-secret false positives for SECRETS_* names #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitjain099 wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −3
Open

Avoid env-var-secret false positives for SECRETS_* names #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/generated/checks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ IgnoredSecrets: []
**Parameters**:

```yaml
name: (?i).*secret.*
name: (?i).*secret([^s].*|$)
value: .+
```
## exposed-services
Expand Down
2 changes: 1 addition & 1 deletion pkg/builtinchecks/yamls/env-var-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ scope:
- DeploymentLike
template: "env-var"
params:
name: "(?i).*secret.*"
name: "(?i).*secret([^s].*|$)"
value: ".+"
15 changes: 14 additions & 1 deletion tests/checks/env-var-secret.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,19 @@ spec:
---
apiVersion: apps/v1
kind: Deployment
metadata:
name: secrets-dir
spec:
template:
spec:
containers:
- name: app
env:
- name: SECRETS_DIR
value: /mnt/secrets
---
apiVersion: apps/v1
kind: Deployment
metadata:
name: app
spec:
Expand All @@ -49,4 +62,4 @@ spec:
- name: app
env:
- name: SECRET_BLAH
value: secretsquirrels
value: secretsquirrels
Loading