wip

Author: Moritz Clasmeier

internal/env/env_test.go

@@ -19,8 +19,8 @@ func TestDetectClusterType_GKE(t *testing.T) {
 	apiResources := []string{"pods", "services", "deployments"}
 
 	result := DetectClusterType(config, apiResources)
-	if result != types.ClusterTypeInfraOpenShift4 {
-		t.Errorf("DetectClusterType() = %v (%s), want %v (%s)", result, result.String(), types.ClusterTypeInfraGKE, types.ClusterTypeInfraGKE.String())
+	if result != types.ClusterTypeInfraGKE {
+		t.Errorf("DetectClusterType() = %v (%s), want %v", result, result.String(), types.ClusterTypeInfraGKE)
 	}
 }
 
@@ -38,7 +38,7 @@ func TestDetectClusterType_GKE_ExactMatch(t *testing.T) {
 
 	result := DetectClusterType(config, apiResources)
 	if result != types.ClusterTypeInfraGKE {
-		t.Errorf("DetectClusterType() = %v (%s), want %v (%s)", result, result.String(), types.ClusterTypeInfraGKE, types.ClusterTypeInfraGKE.String())
+		t.Errorf("DetectClusterType() = %v (%s), want %v", result, result.String(), types.ClusterTypeInfraGKE)
 	}
 }
 
@@ -61,7 +61,7 @@ func TestDetectClusterType_OpenShift4(t *testing.T) {
 
 	result := DetectClusterType(config, apiResources)
 	if result != types.ClusterTypeInfraOpenShift4 {
-		t.Errorf("DetectClusterType() = %v (%s), want %v (%s)", result, result.String(), types.ClusterTypeInfraOpenShift4, types.ClusterTypeInfraOpenShift4.String())
+		t.Errorf("DetectClusterType() = %v (%s), want %v", result, result.String(), types.ClusterTypeInfraOpenShift4)
 	}
 }
 
@@ -154,7 +154,7 @@ func TestDetectClusterType_EmptyContext(t *testing.T) {
 	}
 }
 
-func TestDetectClusterType_Unknown(t *testing.T) {
+func TestDetectClusterType_Minikube(t *testing.T) {
 	config := KubeConfig{
 		CurrentContext: "minikube",
 		Clusters: []KubeCluster{
@@ -167,8 +167,8 @@ func TestDetectClusterType_Unknown(t *testing.T) {
 	apiResources := []string{"pods", "services"}
 
 	result := DetectClusterType(config, apiResources)
-	if result != types.ClusterTypeUnknown {
-		t.Errorf("DetectClusterType() = %v (%s), want %v", result, result.String(), types.ClusterTypeUnknown)
+	if result != types.ClusterTypeMinikube {
+		t.Errorf("DetectClusterType() = %v (%s), want %v", result, result.String(), types.ClusterTypeMinikube)
 	}
 }
 

internal/types/cluster_type.go

@@ -28,15 +28,15 @@ func (ct ClusterType) String() string {
 	case ClusterTypeInfraOpenShift4:
 		return "OpenShift4"
 	case ClusterTypeKind:
-		return "kind"
+		return "Kind"
 	case ClusterTypeMinikube:
 		return "minikube"
 	case ClusterTypeK3s:
 		return "k3s"
 	case ClusterTypeCRC:
 		return "crc"
 	default:
-		return "unknown"
+		return "Unknown"
 	}
 }