Rename dumpClusterOnFailure to dumpClusterStateOnFailure

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Moritz Clasmeier

tests/e2e/basic_test.go

@@ -11,7 +11,7 @@ import (
 
 // TestDeployBothSimple tests deploying both components together (simplest scenario)
 func TestDeployBothSimple(t *testing.T) {
-	dumpClusterOnFailure(t)
+	dumpClusterStateOnFailure(t)
 
 	// Create temporary envrc file
 	envrcFile, err := os.CreateTemp(t.TempDir(), ".envrc.roxie-test-*")

tests/e2e/e2e_test.go

@@ -39,7 +39,7 @@ func TestMain(m *testing.M) {
 }
 
 func TestDeployBothComponentsTogetherInSingleNamespace(t *testing.T) {
-	dumpClusterOnFailure(t)
+	dumpClusterStateOnFailure(t)
 
 	// Create temporary envrc file.
 	envrcFile, err := os.CreateTemp(t.TempDir(), ".envrc.roxie-test-*")

tests/e2e/helpers.go

@@ -246,7 +246,7 @@ var clusterDumpNamespaces = []string{
 	"stackrox",
 }
 
-func dumpClusterOnFailure(t *testing.T) {
+func dumpClusterStateOnFailure(t *testing.T) {
 	t.Helper()
 	t.Cleanup(func() {
 		if !t.Failed() {

tests/e2e/olm_switch_test.go

@@ -65,7 +65,7 @@ func verifyOperatorDeploymentExists(t *testing.T) {
 
 // TestOLMToNonOLMSwitch tests switching from OLM operator to non-OLM operator
 func TestOLMToNonOLMSwitch(t *testing.T) {
-	dumpClusterOnFailure(t)
+	dumpClusterStateOnFailure(t)
 
 	if os.Getenv("SKIP_OLM_TESTS") != "" {
 		t.Skip("SKIP_OLM_TESTS is set")
@@ -115,7 +115,7 @@ func TestOLMToNonOLMSwitch(t *testing.T) {
 
 // TestNonOLMToOLMSwitch tests switching from non-OLM operator to OLM operator
 func TestNonOLMToOLMSwitch(t *testing.T) {
-	dumpClusterOnFailure(t)
+	dumpClusterStateOnFailure(t)
 
 	if os.Getenv("SKIP_OLM_TESTS") != "" {
 		t.Skip("SKIP_OLM_TESTS is set")
@@ -165,7 +165,7 @@ func TestNonOLMToOLMSwitch(t *testing.T) {
 
 // TestOLMOperatorVersionUpgrade tests that OLM operator version mismatches trigger teardown and redeploy
 func TestOLMOperatorVersionUpgrade(t *testing.T) {
-	dumpClusterOnFailure(t)
+	dumpClusterStateOnFailure(t)
 
 	if os.Getenv("SKIP_OLM_TESTS") != "" {
 		t.Skip("SKIP_OLM_TESTS is set")
@@ -229,7 +229,7 @@ func TestOLMOperatorVersionUpgrade(t *testing.T) {
 
 // TestSecuredClusterWithOLMSwitch tests that secured-cluster deployment also respects OLM mode switches
 func TestSecuredClusterWithOLMSwitch(t *testing.T) {
-	dumpClusterOnFailure(t)
+	dumpClusterStateOnFailure(t)
 
 	if os.Getenv("SKIP_OLM_TESTS") != "" {
 		t.Skip("SKIP_OLM_TESTS is set")