wip

Author: Moritz Clasmeier

cmd/deploy.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"os"
+	"reflect"
 	"strings"
 	"time"
 
@@ -216,6 +217,13 @@ Examples:
 			if err := yaml.Unmarshal([]byte(yamlValue), &val); err != nil {
 				return fmt.Errorf("failed to unmarshal value '%s' for key '%s': %w", yamlValue, key, err)
 			}
+			// SetNestedField requires JSON-compatible types: float64 for numbers, not int.
+			switch v := val.(type) {
+			case int:
+				val = float64(v)
+			case int64:
+				val = float64(v)
+			}
 			pathElements := strings.Split(key, ".")
 			u, err := helpers.StructToMap(settings)
 			if err != nil {
@@ -224,7 +232,17 @@ Examples:
 			if err := unstructured.SetNestedField(u, val, pathElements...); err != nil {
 				return err
 			}
-			return helpers.MapToStruct(u, settings)
+			var updatedSettings deployer.Config
+			if err := helpers.MapToStruct(u, &updatedSettings); err != nil {
+				return err
+			}
+			if reflect.DeepEqual(settings, &updatedSettings) {
+				return fmt.Errorf("Set expression %q had no effect -- typo?", expr)
+			}
+			*settings = updatedSettings
+
+			return nil
+
 		},
 	), "set", "Set expressions, e.g. securedCluster.spec.clusterName=sensor")
 

internal/deployer/config.go

@@ -215,5 +215,6 @@ func DefaultSecuredClusterConfig() SecuredClusterConfig {
 	return SecuredClusterConfig{
 		DeployTimeout: DefaultSecuredClusterWaitTimeout,
 		Namespace:     "acs-sensor",
+		Spec:          make(map[string]interface{}),
 	}
 }