Skip to content

Commit f77598e

Browse files
author
Moritz Clasmeier
committed
Apply user defaults for deploy/teardown commands.
1 parent baf3f6c commit f77598e

2 files changed

Lines changed: 27 additions & 0 deletions

File tree

cmd/deploy.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,19 @@ func runDeploy(cmd *cobra.Command, args []string) error {
263263
return err
264264
}
265265

266+
// Start with default configuration.
267+
deploySettings := deployer.DefaultConfig()
268+
269+
// Apply user config on top (overriding defaults).
270+
if err := tryApplyUserDefaults(globalLogger, &deploySettings); err != nil {
271+
return fmt.Errorf("applying user config: %w", err)
272+
}
273+
274+
// Apply changes from arg parsing.
275+
if err := mergo.Merge(deploySettings, deploySettingsFromArgs, mergo.WithOverride, mergo.WithoutDereference); err != nil {
276+
return fmt.Errorf("applying config patches from command line argument: %w", err)
277+
}
278+
266279
if deploySettings.Roxie.Version != "" {
267280
log.Dimf("Using main image tag %s", deploySettings.Roxie.Version)
268281
} else {

cmd/teardown.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"fmt"
66
"time"
77

8+
"dario.cat/mergo"
89
"github.com/spf13/cobra"
910
"github.com/stackrox/roxie/internal/component"
1011
"github.com/stackrox/roxie/internal/deployer"
@@ -55,6 +56,19 @@ func runTeardown(cmd *cobra.Command, args []string) error {
5556
return nil
5657
}
5758

59+
// Start with default configuration.
60+
deploySettings := deployer.DefaultConfig()
61+
62+
// Apply user config on top (overriding defaults).
63+
if err := tryApplyUserDefaults(globalLogger, &deploySettings); err != nil {
64+
return fmt.Errorf("applying user config: %w", err)
65+
}
66+
67+
// Apply changes from arg parsing.
68+
if err := mergo.Merge(deploySettings, deploySettingsFromArgs, mergo.WithOverride, mergo.WithoutDereference); err != nil {
69+
return fmt.Errorf("applying config patches from command line argument: %w", err)
70+
}
71+
5872
d, err := deployer.New(log)
5973
if err != nil {
6074
return fmt.Errorf("failed to create deployer: %w", err)

0 commit comments

Comments
 (0)