Merge pull request #7408 from federico-stacks/test/fix-proptest-filter

test: fix proptest failing for too many local rejects due to prop_filter on high case count

Author: federico-stacks

clarity/src/vm/tests/sequences.rs

@@ -1810,22 +1810,30 @@ fn buff_chunk_strategy() -> impl Strategy<Value = Vec<u8>> {
     prop::collection::vec(any::<u8>(), 0..=32)
 }
 
+/// Printable-ASCII bytes (`0x20..=0x7E`) excluding `"` and `\`, which need
+/// escaping in a Clarity string literal.
+///
+/// Callers sample from this set directly rather than `prop_filter`-ing the full
+/// range: a per-byte filter rejects `"`/`\` ~2% of the time, and with many
+/// bytes per case the cumulative local rejects blow past proptest's cap under
+/// high case counts (aborting the run).
+fn allowed_ascii_bytes() -> Vec<u8> {
+    (0x20u8..=0x7Eu8)
+        .filter(|b| *b != b'"' && *b != b'\\')
+        .collect()
+}
+
 /// Random printable-ASCII bytes (no `"` or `\`) for a string-ascii arg.
 fn ascii_chunk_strategy() -> impl Strategy<Value = Vec<u8>> {
-    prop::collection::vec(
-        (0x20u8..=0x7Eu8).prop_filter("not quote or backslash", |b| *b != b'"' && *b != b'\\'),
-        0..=32,
-    )
+    prop::collection::vec(prop::sample::select(allowed_ascii_bytes()), 0..=32)
 }
 
 /// Random Unicode chars (printable ASCII + BMP + emoji) for a string-utf8 arg.
 fn utf8_chunk_strategy() -> impl Strategy<Value = Vec<char>> {
     prop::collection::vec(
         prop_oneof![
             // Printable ASCII excluding `"` and `\`
-            (0x20u8..=0x7Eu8)
-                .prop_filter("not quote or backslash", |b| *b != b'"' && *b != b'\\')
-                .prop_map(|b| b as char),
+            prop::sample::select(allowed_ascii_bytes()).prop_map(|b| b as char),
             // BMP non-control non-surrogate codepoints
             (0xA1u32..=0xD7FF).prop_filter_map("valid bmp char", |n| {
                 char::from_u32(n).filter(|c| !c.is_control())