Merge branch 'stx-develop' into feat/stackerdb-bandwith-config

Author: federico-stacks

.cargo/config.toml

@@ -1,7 +1,7 @@
 [alias]
 stacks-node = "run --package stacks-node --"
 fmt-stacks = "fmt -- --config group_imports=StdExternalCrate,imports_granularity=Module"
-clippy-stacks = "clippy -p stx-genesis -p libstackerdb -p stacks-signer -p pox-locking -p clarity-types -p clarity -p libsigner -p stacks-common -p clarity-cli -p stacks-cli -p stacks-inspect -p stacks-profiler -p stacks-profiler-macros --no-deps --tests --all-features -- -D warnings -Aclippy::unnecessary_lazy_evaluations"
+clippy-stacks = "clippy -p stx-genesis -p libstackerdb -p stacks-signer -p pox-locking -p clarity-types -p clarity -p libsigner -p stacks-common -p stacks-codec -p clarity-cli -p stacks-cli -p stacks-inspect -p stacks-profiler -p stacks-profiler-macros --no-deps --tests --all-features -- -D warnings -Aclippy::unnecessary_lazy_evaluations"
 clippy-stackslib = "clippy -p stackslib --no-deps -- -Aclippy::all -Wclippy::indexing_slicing -Wclippy::nonminimal_bool -Wclippy::clone_on_copy"
 
 # Uncomment to improve performance slightly, at the cost of portability

.github/workflows/_ci.yml

@@ -124,9 +124,15 @@ jobs:
 
   ############################################################################
   ### Release Check
-  ### 
+  ###
   ### Checks if this is a release build
   ### If true, will execute release jobs
+  ###
+  ### Release detection only matters on the public repo. This job is depended
+  ### on only by the release-specific jobs (tests-epoch, create-release); the
+  ### regular CI/test jobs are intentionally decoupled from it, so it is safe
+  ### for this job to be skipped (and cascade-skip those release jobs) on
+  ### private forks.
   ############################################################################
   check-release:
     name: "Check: Release"
@@ -167,7 +173,6 @@ jobs:
     name: "Check: Cargo Hack"
     needs:
       - check-changelog
-      - check-release
       - check-rustfmt
       - setup-env
     if: >-
@@ -181,7 +186,6 @@ jobs:
     name: "Check: Constants"
     needs:
       - check-changelog
-      - check-release
       - check-rustfmt
       - setup-env
     if: >-
@@ -195,11 +199,9 @@ jobs:
     name: "Setup: Test Caches"
     needs:
       - check-changelog
-      - check-release
       - check-rustfmt
       - setup-env
     if: >-
-      needs.check-release.outputs.is_release == 'true' ||
       needs.setup-env.outputs.job-should-run == 'true'
     uses: ./.github/workflows/setup-test-caches.yml
     with:
@@ -213,12 +215,10 @@ jobs:
     name: "Tests: Stacks Core"
     needs:
       - check-changelog
-      - check-release
       - check-rustfmt
       - setup-test-caches
       - setup-env
     if: >-
-      needs.check-release.outputs.is_release == 'true' ||
       needs.setup-env.outputs.job-should-run == 'true'
     uses: ./.github/workflows/tests-stacks-core.yml
     with:
@@ -231,12 +231,10 @@ jobs:
     name: "Tests: Bitcoin"
     needs:
       - check-changelog
-      - check-release
       - check-rustfmt
       - setup-test-caches
       - setup-env
     if: >-
-      needs.check-release.outputs.is_release == 'true' ||
       needs.setup-env.outputs.job-should-run == 'true'
     uses: ./.github/workflows/tests-bitcoin.yml
     with:
@@ -250,11 +248,9 @@ jobs:
     needs:
       - check-changelog
       - check-rustfmt
-      - check-release
       - setup-test-caches
       - setup-env
     if: >-
-      needs.check-release.outputs.is_release == 'true' ||
       needs.setup-env.outputs.job-should-run == 'true'
     uses: ./.github/workflows/tests-bitcoin-rpc.yml
     with:
@@ -269,11 +265,9 @@ jobs:
     needs:
       - check-changelog
       - check-rustfmt
-      - check-release
       - setup-test-caches
       - setup-env
     if: >-
-      needs.check-release.outputs.is_release == 'true' ||
       needs.setup-env.outputs.job-should-run == 'true'
     uses: ./.github/workflows/tests-p2p.yml
     with:

.github/workflows/check-cargo-hack.yml

@@ -91,10 +91,12 @@ jobs:
             -p clarity \
             -p clarity-types \
             -p stacks-common \
+            -p stacks-codec \
             --each-feature \
             --no-dev-deps \
             --exclude-features=default,rusqlite,ctrlc-handler,wasm-deterministic,testing \
-            --features=wasm-web
+            --features=wasm-web \
+            --target wasm32-unknown-unknown
 
       # Run cargo-hack for WASM Deterministic
       - name: Run cargo hack check (WASM Deterministic)
@@ -119,24 +121,26 @@ jobs:
           ref: ${{ github.event.pull_request.head.sha || github.ref }}
           persist-credentials: false
 
-      # Setup the rust toolchain for specified target
+      # Setup the rust toolchain for specified target.
+      # Pin to a specific nightly: an unpinned `nightly` tracks the latest build
+      # and breaks the job whenever rustc tightens lints (e.g. unused imports).
       - name: Setup Rust Toolchain
         uses: ./.github/actions/setup-rust-toolchain
         with:
-          toolchain: nightly
+          toolchain: nightly-2026-06-07
 
       # Fuzz check clarity targets
       - name: Check fuzz targets (clarity)
         run: |
-          cargo +nightly check \
+          cargo +nightly-2026-06-07 check \
             --manifest-path clarity/fuzz/Cargo.toml \
             --bins \
             --locked
 
       # Fuzz check stackslib targets
       - name: Check fuzz targets (stackslib)
         run: |
-          cargo +nightly check \
+          cargo +nightly-2026-06-07 check \
             --manifest-path stackslib/fuzz/Cargo.toml \
             --bins \
             --locked

.github/workflows/tests-proptest-extra.yml

@@ -50,7 +50,7 @@ concurrency:
 # Set default env vars
 env:
   RUST_BACKTRACE: full
-  TEST_TIMEOUT: 30
+  TEST_TIMEOUT: 60
   # Minimum number of PR approvals required before running the tests
   REQUIRED_APPROVALS: 2
   # Number of generated cases to run per selected proptest.
@@ -283,7 +283,11 @@ jobs:
 
       # List every test present on the HEAD branch.
       - name: List HEAD branch tests
+        env:
+          HEAD_REF: ${{ github.event.pull_request.head.ref || github.ref_name }}
         run: |
+          echo "Head branch: $HEAD_REF"
+
           cargo nextest list \
             --archive-file ${{ needs.setup-env.outputs.test-archive-file }} \
             -Tjson 2>/dev/null \
@@ -296,56 +300,52 @@ jobs:
           | sort > /tmp/head-tests.txt
           echo "HEAD tests: $(wc -l < /tmp/head-tests.txt)"
 
-      # Check out the base branch into a temporary git worktree and compile
-      # it to list its tests.
-      #
-      # CARGO_TARGET_DIR is pointed at the HEAD workspace's target/ directory.
-      # Anything unchanged between HEAD and BASE (external deps and
-      # unmodified stacks-core crates) is reused, so only the crates
-      # that actually differ need recompiling.
+      # Check out the base branch into a temporary git worktree and compile it
+      # to list its tests, building in the worktree's own target/. The worktree
+      # (and its build output) is removed afterwards.
       #
-      # NOTE:
-      # Overwriting HEAD binaries in target/ is harmless — the test-run step
-      # uses --archive-file, which extracts HEAD binaries into a temp dir and
-      # never reads from target/.
-      #
-      # Reusing HEAD's target/ is only effective when testenv fell back to a local
-      # build (cache miss): that build uses no special RUSTFLAGS, so the artifacts
-      # are compatible and Rust only recompiles the crates that differ from BASE.
-      # When testenv succeeds (cache hit), target/ contains artifacts built with
-      # -Cinstrument-coverage (from manage-test-caches). The flag mismatch invalidates
-      # every fingerprint, forcing a full recompile regardless — no faster than
-      # using a fresh target directory (and it's not worth using same flag either).
+      # This is always a full compile: the ./target/debug/ restored by "Restore
+      # Test Archive Cache" was built with -C instrument-coverage by
+      # setup-test-caches, so its fingerprints never match this list-only build
+      # and there is nothing to reuse. RUSTFLAGS only allows warnings here — the
+      # job-wide `-D warnings` would otherwise turn a benign warning into a hard
+      # error and leave an empty list.
       - name: List BASE branch tests
         env:
           BASE_REF: ${{ github.event.pull_request.base.ref || inputs.base_ref }}
+          RUSTFLAGS: "-A warnings"
+        shell: bash
         run: |
           echo "Base branch: $BASE_REF"
 
           git fetch --depth=1 origin "$BASE_REF"
           git worktree add --detach /tmp/base-worktree "origin/$BASE_REF"
 
-          # Capture HEAD workspace root before entering the worktree
-          head_target="$(pwd)/target"
-
+          # Build in the worktree's own target/ (no HEAD target/ reuse — see note).
           pushd /tmp/base-worktree
-          CARGO_TARGET_DIR="$head_target" \
-          cargo nextest list \
-            -Tjson 2>/dev/null \
-          | jq -r '
+          cargo nextest list -Tjson > /tmp/base-list.json
+          popd
+
+          # Remove the worktree along with its build output (--force because the
+          # compile above populated its target/).
+          git worktree remove --force /tmp/base-worktree
+          git worktree prune
+          
+          jq -r '
               .["rust-suites"]
               | to_entries[]
               | .value.testcases
               | keys[]
-            ' \
+            ' /tmp/base-list.json \
           | sort > /tmp/base-tests.txt
-          popd
-
-          # Worktree source files are clean (build output went to HEAD_TARGET)
-          git worktree remove /tmp/base-worktree
-          git worktree prune
+          
+          base_count=$(wc -l < /tmp/base-tests.txt)
+          echo "Base tests: $base_count"
 
-          echo "Base tests: $(wc -l < /tmp/base-tests.txt)"
+          if [ "$base_count" -eq 0 ]; then
+            echo "::error::BASE test listing is empty — aborting to avoid treating all HEAD tests as new."
+            exit 1
+          fi
 
       # Compare the HEAD and base test lists and keep only tests that are new in HEAD.
       # Then filter to only those tagged with :t::...:t_prop:, i.e. test names of the form:

Cargo.lock

@@ -43,6 +43,7 @@ rusqlite = { version = "0.31.0", features = ["blob", "serde_json", "i128_blob",
 thiserror = "1.0.65"
 tikv-jemallocator = "0.5.4"
 toml = "0.5.6"
+variant_count = "1.1"
 
 # Other dependencies
 libc = { version = "0.2.182", default-features = false }

Cargo.toml

@@ -0,0 +1 @@
+Prevent blocks that contain transactions with non-normalized "high S" secp256k1 signatures. Consensus still allows them (this will be changed in a future epoch), but miners won't mine them and signers won't sign them.

changelog.d/7163-reject-high-s-signature-tx.fixed

@@ -0,0 +1 @@
+Rust toolchain bumped from 1.94.0 to 1.96.0 and new clippy lint warnings addressed

changelog.d/7348-rust-toolchain-1.96.0.changed

@@ -0,0 +1 @@
+Drop unused p2p message types (BlocksAvailable, MicroblocsAvailable, BlocksData)

changelog.d/drop-unused-p2p-msg.changed

@@ -0,0 +1 @@
+Add snapshot copy of canonical epoch 2.x block files, confirmed microblock streams, and Nakamoto staging blocks into squashed output.