pox-locking#7195
Merged
brice-stacks merged 15 commits intoMay 13, 2026
Merged
Conversation
Contributor
Author
|
I need to handle deploying sBTC in more of the tests. |
Coverage Report for CI Build 25578453708Warning No base build found for commit Coverage: 46.434%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
The tests need to deploy an sBTC contract so that the pox-5 contract can refer to it at the epoch 4.0 activation.
aaronb-stacks
approved these changes
May 11, 2026
Contributor
aaronb-stacks
left a comment
aaronb-stacks
left a comment
There was a problem hiding this comment.
LGTM -- just a note about being careful with the pox-5.clar move/linking.
hstove-stacks
approved these changes
May 11, 2026
hstove-stacks
approved these changes
May 11, 2026
Contributor
hstove-stacks
left a comment
hstove-stacks
left a comment
There was a problem hiding this comment.
LGTM! I think we might want to tweak some the contract value setters as we get closer to launch, but I don't think that should block this PR at all.
Also, thanks a ton for the integration tests, there is a lot of really helpful setup code in there.
Contributor
Author
|
I'll review and fix those failing tests before merging. |
Bump the default test 4.0 activation height so that tests that do not intend to test epoch 4 behavior stay in 3.4.
Clarigen needed to run again to get the new types for `register-for-bond` and the new `set-bond-admin` function. Then the setup needed to set the bond admin to the deployer.
aaronb-stacks
approved these changes
May 13, 2026
hstove-stacks
approved these changes
May 13, 2026
brice-stacks
merged commit 9b31092
into
stacks-network:pox-wf-integration
662 of 664 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds pox-locking for the pox-5 and adds some integration tests.