Skip to content

pox-locking#7195

Merged
brice-stacks merged 15 commits into
stacks-network:pox-wf-integrationfrom
brice-stacks:feat/pox-wf-locking
May 13, 2026
Merged

pox-locking#7195
brice-stacks merged 15 commits into
stacks-network:pox-wf-integrationfrom
brice-stacks:feat/pox-wf-locking

Conversation

@brice-stacks

Copy link
Copy Markdown
Contributor

This adds pox-locking for the pox-5 and adds some integration tests.

@brice-stacks brice-stacks requested a review from hstove-stacks May 8, 2026 20:42
@brice-stacks

Copy link
Copy Markdown
Contributor Author

I need to handle deploying sBTC in more of the tests.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 25578453708

Warning

No base build found for commit f8683bf on pox-wf-integration.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 46.434%

Details

  • Patch coverage: 1465 uncovered changes across 17 files (118 of 1583 lines covered, 7.45%).

Uncovered Changes

Top 10 Files by Coverage Impact Changed Covered %
pox-locking/src/pox_5.rs 1018 0 0.0%
clarity/src/vm/database/structures.rs 240 29 12.08%
clarity/src/vm/clarity.rs 44 0 0.0%
stackslib/src/clarity_vm/clarity.rs 43 1 2.33%
stackslib/src/util_lib/signed_structured_data.rs 34 0 0.0%
stackslib/src/chainstate/stacks/boot/mod.rs 26 0 0.0%
clarity/src/vm/contexts.rs 16 0 0.0%
pox-locking/src/lib.rs 18 3 16.67%
stackslib/src/chainstate/nakamoto/signer_set.rs 19 6 31.58%
clarity/src/vm/database/clarity_db.rs 16 4 25.0%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 218668
Covered Lines: 101537
Line Coverage: 46.43%
Coverage Strength: 12467217.45 hits per line

💛 - Coveralls

The tests need to deploy an sBTC contract so that the pox-5 contract can
refer to it at the epoch 4.0 activation.
Comment thread stackslib/src/chainstate/stacks/boot/pox-5.clar

@aaronb-stacks aaronb-stacks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- just a note about being careful with the pox-5.clar move/linking.

Comment thread stackslib/src/chainstate/nakamoto/signer_set.rs
Comment thread stackslib/src/clarity_vm/clarity.rs Outdated

@hstove-stacks hstove-stacks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we might want to tweak some the contract value setters as we get closer to launch, but I don't think that should block this PR at all.

Also, thanks a ton for the integration tests, there is a lot of really helpful setup code in there.

@brice-stacks

Copy link
Copy Markdown
Contributor Author

I'll review and fix those failing tests before merging.

Bump the default test 4.0 activation height so that tests that do not
intend to test epoch 4 behavior stay in 3.4.
Clarigen needed to run again to get the new types for
`register-for-bond` and the new `set-bond-admin` function. Then the
setup needed to set the bond admin to the deployer.
@brice-stacks brice-stacks merged commit 9b31092 into stacks-network:pox-wf-integration May 13, 2026
662 of 664 checks passed
@brice-stacks brice-stacks deleted the feat/pox-wf-locking branch May 13, 2026 14:52
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants