L1 bond integration test#7223
Merged
brice-stacks merged 15 commits intoMay 29, 2026
Merged
Conversation
brice-stacks
force-pushed
the
test/l1-bond-integration
branch
from
a44d4fa to
29c5f76
Compare
Coverage Report for CI Build 26263073494Coverage increased (+0.007%) to 85.966%Details
Uncovered Changes
Coverage Regressions6164 previously-covered lines in 97 files lost coverage.
Coverage Stats
💛 - Coveralls |
The simnet doesn't provide a way to do much real testing with the L1 data, so we need to remove those from the unit tests and check that behavior in integration tests.
The `construct-lockup-script` now correctly handles the `unlock-bytes` from the user. The `check_pox_5_register_for_bond_l1_lockup_lifecycle` test is extended to verify that the staker, and no one else, can spend the BTC when the lock expires.
Contributor
Author
|
This PR includes the basic L1 bond integration test, as described, as well as the fixes to the lock script construction and a complete test of an L1 early unlock. |
aaronb-stacks
left a comment
aaronb-stacks
left a comment
Contributor
There was a problem hiding this comment.
This is awesome! LGTM, but I'd appreciate the new tests landing in a new file rather than expanding the bloat in nakamoto_integrations
aaronb-stacks
approved these changes
May 29, 2026
hstove-stacks
approved these changes
May 29, 2026
hstove-stacks
left a comment
hstove-stacks
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Fantastic work on this
brice-stacks
merged commit b6fc7f5
into
stacks-network:pox-wf-integration
221 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a complete L1 lockup integration test.