Skip to content

fix: unchecked integer underflow in p2p neighbor sort#7415

Open
benjamin-stacks wants to merge 1 commit into
stacks-network:developfrom
benjamin-stacks:fix/neighbor-sort-underflow
Open

fix: unchecked integer underflow in p2p neighbor sort#7415
benjamin-stacks wants to merge 1 commit into
stacks-network:developfrom
benjamin-stacks:fix/neighbor-sort-underflow

Conversation

@benjamin-stacks

Copy link
Copy Markdown
Contributor

My node (compiled in debug mode) just crashed after the system clock was synced.

My node (compiled in debug mode) just crashed after the system clock was
synced.
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29328759718

Coverage increased (+0.9%) to 86.568%

Details

  • Coverage increased (+0.9%) from the base build.
  • Patch coverage: 2 of 2 lines across 1 file are fully covered (100%).
  • 11972 coverage regressions across 166 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

11972 previously-covered lines in 166 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
stackslib/src/chainstate/burn/db/sortdb.rs 638 90.43%
stackslib/src/chainstate/stacks/db/blocks.rs 528 89.93%
stackslib/src/chainstate/nakamoto/mod.rs 490 84.77%
stackslib/src/config/mod.rs 324 78.53%
stackslib/src/net/relay.rs 313 75.24%
stackslib/src/net/mod.rs 312 78.22%
stackslib/src/chainstate/stacks/index/storage.rs 277 82.41%
clarity/src/vm/database/clarity_db.rs 273 82.02%
stackslib/src/chainstate/stacks/db/transactions.rs 269 97.13%
stackslib/src/chainstate/stacks/miner.rs 261 83.62%

Coverage Stats

Coverage Status
Relevant Lines: 231325
Covered Lines: 200253
Line Coverage: 86.57%
Coverage Strength: 19554568.93 hits per line

💛 - Coveralls

@francesco-stacks francesco-stacks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants