ci: code cleanup

Code code cleanup based on latest codex checks

Author: stacksjb

.github/workflows/codecov.yml

@@ -13,6 +13,8 @@ jobs:
   coverage:
     runs-on: ubuntu-latest
     steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
 
       - name: Install ALSA development files
         run: sudo apt-get update && sudo apt-get install -y libasound2-dev
@@ -22,9 +24,6 @@ jobs:
       - name: Build and test
         run: cargo test --workspace --all-targets
 
-      - name: Checkout code
-        uses: actions/checkout@v3
-
       - name: Install grcov
         run: cargo install grcov
 

.github/workflows/rust-clippy.yml

@@ -42,11 +42,12 @@ jobs:
         run: cargo install clippy-sarif sarif-fmt
 
       - name: Run rust-clippy
-        run:
-          cargo clippy
-          --all-features
-          --message-format=json | clippy-sarif | tee rust-clippy-results.sarif | sarif-fmt
-        continue-on-error: true
+        run: |
+          set -o pipefail
+          cargo clippy \
+            --all-targets \
+            --all-features \
+            --message-format=json | clippy-sarif | tee rust-clippy-results.sarif | sarif-fmt
 
       - name: Upload analysis results to GitHub
         uses: github/codeql-action/upload-sarif@v3

Cargo.lock

@@ -18,5 +18,6 @@ csv = "1.4.0"
 
 
 [dev-dependencies]
+assert_cmd = "2.2.1"
 serial_test = "3.4.0"
 tempfile = "3.27.0"