feat(protocol): validate requirement-id uniqueness in CI (#2050)#2098
Merged
glennmichael123 merged 1 commit intoJul 22, 2026
Merged
Conversation
Protocol 1.0 ratification requires requirement ids to be unique and validated in CI (#2050), but nothing enforced it — `sync-suite.ts` only checked the vendored suite's file digests against the lock, and the catalog schema has no uniqueness constraint. A duplicate id arriving from the RFC source would go unnoticed. Add `checkCatalog()` to the `protocol:check` path: it loads the vendored `catalog.json`, asserts every requirement has a non-empty string id, and fails on any duplicate. Extracted `duplicateRequirementIds` as a pure, unit-tested helper, and guarded the CLI dispatch behind `import.meta.main` so the module is importable (matching the sibling protocol scripts). Scopes only the "unique + validated in CI" acceptance criterion of #2050; the normative inventory, profile/badge ratification, and whitepaper authoring live in the rfcs/whitepaper repos and remain open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements one concrete acceptance criterion of #2050 - "Requirement IDs are unique and validated in CI." Nothing enforced it:
sync-suite.tsonly digest-checked the vendored suite.checkCatalog()added to theprotocol:checkpath (protocol-conformance CI): loads the vendoredcatalog.json, requires a non-empty stringidon every requirement, fails on any duplicate.duplicateRequirementIdshelper; dispatch guarded behindimport.meta.main.protocol:checkprintsProtocol catalog: 47 requirement ids, all unique; 4 unit tests; pickier clean. Scope: the code-enforceable slice; the whitepaper authoring + ratification in #2050 remain open.🤖 Generated with Claude Code