fix: ruby should use pre-release seperator (#201)

Author: ms-jpq

__snapshots__/version-rb.ts.js

@@ -67,7 +67,7 @@ exports['version.rb updateContent updates prerelease versions in version.rb 1']
 module Google
   module Cloud
     module Bigtable
-      VERSION = "10.0.0-alpha1".freeze
+      VERSION = "10.0.0.pre.alpha1".freeze
     end
   end
 end

src/updaters/ruby/common.ts

@@ -28,14 +28,16 @@ export const RUBY_VERSION_REGEX = /((\d+).(\d)+.(\d+)(.\w+.*)?)/g;
  */
 export function stringifyRubyVersion(
   version: Version,
-  useDotPrePreleaseSeperator = false
+  useDotPrePreleaseSeperator = true
 ) {
   if (!useDotPrePreleaseSeperator) {
     return version.toString();
   }
 
   return `${version.major}.${version.minor}.${version.patch}${
-    version.preRelease ? `.${version.preRelease}` : ''
+    version.preRelease
+      ? `.pre.${version.preRelease.replace(/^[.-]|[.-]$/g, '')}`
+      : ''
   }`;
 }
 

test/updaters/ruby/common.ts

@@ -48,9 +48,9 @@ describe('ruby-common', () => {
       ['1.2.3', '1.2.3'],
       ['1.2.10', '1.2.10'],
       ['15.10.22', '15.10.22'],
-      ['1.0.0-alpha', '1.0.0-alpha'],
-      ['1.0.0-alpha1', '1.0.0-alpha1'],
-      ['2.0.0-rc1', '2.0.0-rc1'],
+      ['1.0.0-alpha', '1.0.0.pre.alpha'],
+      ['1.0.0-alpha1', '1.0.0.pre.alpha1'],
+      ['2.0.0-rc1', '2.0.0.pre.rc1'],
     ];
 
     testTable.forEach(([input, expected]) => {
@@ -87,10 +87,10 @@ describe('ruby-common', () => {
         ['1.2.3', '1.2.3'],
         ['1.2.10', '1.2.10'],
         ['15.10.22', '15.10.22'],
-        ['1.0.0-alpha', '1.0.0.alpha'],
-        ['1.0.0-alpha1', '1.0.0.alpha1'],
-        ['2.0.0-beta', '2.0.0.beta'],
-        ['2.0.0-rc1', '2.0.0.rc1'],
+        ['1.0.0-alpha', '1.0.0.pre.alpha'],
+        ['1.0.0-alpha1', '1.0.0.pre.alpha1'],
+        ['2.0.0-beta', '2.0.0.pre.beta'],
+        ['2.0.0-rc1', '2.0.0.pre.rc1'],
       ];
 
       testTable.forEach(([input, expected]) => {

test/updaters/version-rb.ts

@@ -12,13 +12,13 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+import {expect} from 'chai';
 import {readFileSync} from 'fs';
-import {resolve} from 'path';
-import snapshot = require('snap-shot-it');
 import {describe, it} from 'mocha';
-import {expect} from 'chai';
+import {resolve} from 'path';
 import {VersionRB} from '../../src/updaters/ruby/version-rb';
 import {Version} from '../../src/version';
+import snapshot = require('snap-shot-it');
 
 const fixturesPath = './test/updaters/fixtures';
 
@@ -31,8 +31,14 @@ describe('version.rb', () => {
       ['0.2.0', '"0.1.0"', '"0.2.0"', true, 'minor'],
       ['0.2.1', '"0.2.0"', '"0.2.1"', true, 'patch'],
       ['0.2.11', '"0.2.10"', '"0.2.11"', true, 'long patch'],
-      ['1.0.0-alpha1', '"0.9.0"', '"1.0.0-alpha1"', true, 'prerelease'],
-      ['1.0.0-beta', '"1.0.0-alpha1"', '"1.0.0-beta"', true, 'prerelease bump'],
+      ['1.0.0-alpha1', '"0.9.0"', '"1.0.0.pre.alpha1"', true, 'prerelease'],
+      [
+        '1.0.0-beta',
+        '"1.0.0-alpha1"',
+        '"1.0.0.pre.beta"',
+        true,
+        'prerelease bump',
+      ],
       ['1.0.0', '"1.0.0.beta"', '"1.0.0"', true, 'major'],
       ['1.0.1', '"1.0.0"', '"1.0.1"', true, 'major patch'],
       ['1.0.0', '"1.0"', '"1.0"', false, 'ignored'],