Skip to content

Commit 397114c

Browse files
committed
refactor: don't use deprecated .Completed property
1 parent fcb4d88 commit 397114c

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

pkg/cmd/build.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ func (c buildCompletionModel) IsCompleted() bool {
523523

524524
// Check if download is completed (if applicable)
525525
downloadIsCompleted := true
526-
if buildTarget.IsCommitCompleted() && stainlessutils.IsGoodCommitConclusion(buildTarget.Commit.Completed.Conclusion) {
526+
if buildTarget.IsCommitCompleted() && buildTarget.IsGoodCommitConclusion() {
527527
if download, ok := c.Build.Downloads[target]; ok {
528528
downloadIsCompleted = download.Status == "completed"
529529
}

pkg/stainlessutils/stainlessutils.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -188,18 +188,18 @@ func (bt *BuildTarget) StepInfo(step string) (status, url, conclusion string) {
188188
if u, ok := stepUnion.(stainless.BuildTargetCommitUnion); ok {
189189
status = u.Status
190190
if u.Status == "completed" {
191-
conclusion = u.Completed.Conclusion
191+
conclusion = u.Conclusion
192192
// Use merge conflict PR URL if available, otherwise use commit URL
193-
if u.Completed.JSON.MergeConflictPr.Valid() {
193+
if u.JSON.MergeConflictPr.Valid() {
194194
url = fmt.Sprintf("https://github.com/%s/%s/pull/%.0f",
195-
u.Completed.MergeConflictPr.Repo.Owner,
196-
u.Completed.MergeConflictPr.Repo.Name,
197-
u.Completed.MergeConflictPr.Number)
198-
} else if u.Completed.JSON.Commit.Valid() {
195+
u.MergeConflictPr.Repo.Owner,
196+
u.MergeConflictPr.Repo.Name,
197+
u.MergeConflictPr.Number)
198+
} else if u.JSON.Commit.Valid() {
199199
url = fmt.Sprintf("https://github.com/%s/%s/commit/%s",
200-
u.Completed.Commit.Repo.Owner,
201-
u.Completed.Commit.Repo.Name,
202-
u.Completed.Commit.Sha)
200+
u.Commit.Repo.Owner,
201+
u.Commit.Repo.Name,
202+
u.Commit.Sha)
203203
}
204204
}
205205
}

0 commit comments

Comments
 (0)