Skip to content

Commit 68b8589

Browse files
meorphismeorphis
andauthored
feat: handle case where there is a fatal error in the base build but not the head (#205)
Co-authored-by: meorphis <eric@stainless.com>
1 parent 60bb9ab commit 68b8589

4 files changed

Lines changed: 38 additions & 0 deletions

File tree

dist/build.js

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/merge.js

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/preview.js

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/outcomes.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,17 @@ export function categorizeOutcome({
166166
: null,
167167
};
168168
}
169+
170+
if (baseConclusion && conclusions.fatal.includes(baseConclusion)) {
171+
return {
172+
isPending: false,
173+
conclusion: headConclusion,
174+
severity: null,
175+
description: `had a "${baseOutcome?.commit?.conclusion}" conclusion in the base build, which improved to "${headConclusion}"`,
176+
isRegression: false,
177+
};
178+
}
179+
169180
if (
170181
conclusions.diagnostic.includes(headConclusion) ||
171182
newDiagnostics.length > 0 ||

0 commit comments

Comments
 (0)