fix: slightly different polling termination condition#208
Merged
Conversation
Member
Author
|
well actually I guess it would affect public-facing behavior due to upload-openapi-spec-action/src/outcomes.ts Lines 338 to 341 in 71d0c64 |
cjquines
reviewed
Mar 11, 2026
Comment on lines
+343
to
+346
| (Object.values(outcomes).some( | ||
| (outcome) => categorizeOutcome({ outcome }).isPending, | ||
| ) && | ||
| Date.now() - pollingStart < maxPollingSeconds * 1000) |
Contributor
There was a problem hiding this comment.
question: shouldn't the parentheses go like (less || some pending) && not timed out?
Contributor
|
i think this should be |
cjquines
approved these changes
Mar 12, 2026
Contributor
cjquines
left a comment
cjquines
left a comment
There was a problem hiding this comment.
approved with comments^
meorphis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use pending outcome rather than completion status, to consolidate our logic about what constitutes "pending", should be a noop for public-facing behavior, slight change for internal behavior where we don't wait for postgen if there's no diff